Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add Belarusian translation #6421

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

pubiqq
Copy link
Contributor

@pubiqq pubiqq commented Jan 11, 2024

No description provided.

Copy link

lumberjack-bot bot commented Jan 11, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

bundlemon bot commented Jan 11, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
386.73KB (+3.72KB +0.97%) +10%
demo/browser/runtime.(hash).js
33.95KB (+108B +0.31%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
214.63KB +10%
demo/browser/polyfills.(hash).js
11.24KB +10%
demo/browser/styles.(hash).css
1.06KB +10%

Total files change +3.83KB +0.59%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.3MB (+12.4KB +0.53%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7cb3ac) 69.51% compared to head (954b375) 69.46%.

❗ Current head 954b375 differs from pull request most recent head 3a89804. Consider uploading reports for the commit 3a89804 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6421      +/-   ##
==========================================
- Coverage   69.51%   69.46%   -0.05%     
==========================================
  Files        1156     1157       +1     
  Lines       12593    12613      +20     
  Branches     1764     1770       +6     
==========================================
+ Hits         8754     8762       +8     
- Misses       3555     3567      +12     
  Partials      284      284              
Flag Coverage Δ
summary 69.46% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

} from '@taiga-ui/addon-doc/tokens';

// TODO: drop in v4.0
export const TUI_DOC_BELARUSIAN: Provider[] = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need that in main branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you wanted to abandon not the addon-doc localization itself, but the way it was organized:

/**
* TODO: think about reorganization in @taiga-ui/i18n way
*/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not introduce localization for addon-doc at this point. Otherwise LGTM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done.

@pubiqq pubiqq force-pushed the feat/belarusian branch 2 times, most recently from 2396b46 to 954b375 Compare January 15, 2024 03:59
} from '@taiga-ui/addon-doc/tokens';

// TODO: drop in v4.0
export const TUI_DOC_BELARUSIAN: Provider[] = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not introduce localization for addon-doc at this point. Otherwise LGTM.

@splincode splincode merged commit afa5ae1 into taiga-family:main Jan 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants