-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): add Belarusian translation #6421
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonFiles updated (2)
Unchanged files (3)
Total files change +3.83KB +0.59% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6421 +/- ##
==========================================
- Coverage 69.51% 69.46% -0.05%
==========================================
Files 1156 1157 +1
Lines 12593 12613 +20
Branches 1764 1770 +6
==========================================
+ Hits 8754 8762 +8
- Misses 3555 3567 +12
Partials 284 284
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
} from '@taiga-ui/addon-doc/tokens'; | ||
|
||
// TODO: drop in v4.0 | ||
export const TUI_DOC_BELARUSIAN: Provider[] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we need that in main branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you wanted to abandon not the addon-doc
localization itself, but the way it was organized:
taiga-ui/projects/addon-doc/tokens/i18n.ts
Lines 3 to 5 in bf3b95a
/** | |
* TODO: think about reorganization in @taiga-ui/i18n way | |
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not introduce localization for addon-doc at this point. Otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, done.
2396b46
to
954b375
Compare
} from '@taiga-ui/addon-doc/tokens'; | ||
|
||
// TODO: drop in v4.0 | ||
export const TUI_DOC_BELARUSIAN: Provider[] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not introduce localization for addon-doc at this point. Otherwise LGTM.
954b375
to
3a89804
Compare
No description provided.