Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): Textfield add new component #6298

Merged
merged 3 commits into from
Dec 21, 2023
Merged

feat(experimental): Textfield add new component #6298

merged 3 commits into from
Dec 21, 2023

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes #

What is the new behaviour?

Copy link

lumberjack-bot bot commented Dec 21, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Dec 21, 2023

Visit the preview URL for this PR (updated for commit 3288ba4):

https://taiga-ui--pr6298-textfield-pjrlgdnh.web.app

(expires Fri, 22 Dec 2023 11:54:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Dec 21, 2023

BundleMon

Files updated (3)
Status Path Size Limits
demo/browser/main.(hash).js
386.38KB (+2.78KB +0.72%) +10%
demo/browser/vendor.(hash).js
218.82KB (+166B +0.07%) +10%
demo/browser/runtime.(hash).js
34.12KB (+33B +0.09%) +10%
Unchanged files (2)
Status Path Size Limits
demo/browser/polyfills.(hash).js
11.24KB +10%
demo/browser/styles.(hash).css
1.41KB +10%

Total files change +2.97KB +0.46%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.31MB (+6.72KB +0.28%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (54efbb8) 71.44% compared to head (3288ba4) 71.41%.
Report is 2 commits behind head on main.

Files Patch % Lines
projects/cdk/services/directive-styles.service.ts 33.33% 3 Missing and 1 partial ⚠️
...ore/directives/dropdown/dropdown-open.directive.ts 0.00% 4 Missing ⚠️
...ves/native-validator/native-validator.directive.ts 0.00% 2 Missing ⚠️
...ts/core/directives/hint/hint-describe.directive.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6298      +/-   ##
==========================================
- Coverage   71.44%   71.41%   -0.03%     
==========================================
  Files        1456     1456              
  Lines       15918    15926       +8     
  Branches     2308     2310       +2     
==========================================
+ Hits        11373    11374       +1     
- Misses       4172     4178       +6     
- Partials      373      374       +1     
Flag Coverage Δ
addon-charts 71.29% <ø> (ø)
addon-doc 59.51% <ø> (ø)
addon-mobile 59.92% <ø> (ø)
addon-table 60.50% <ø> (ø)
addon-tablebars 96.15% <ø> (ø)
cdk 77.95% <25.00%> (-0.13%) ⬇️
core 76.39% <0.00%> (-0.05%) ⬇️
kit 70.13% <ø> (ø)
summary 71.41% <14.28%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waterplea waterplea force-pushed the textfield branch 3 times, most recently from ade706b to 7f93fc5 Compare December 21, 2023 10:54
@waterplea waterplea merged commit f72522b into main Dec 21, 2023
36 checks passed
@waterplea waterplea deleted the textfield branch December 21, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants