-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(experimental): Icon
add new component
#5872
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Visit the preview URL for this PR (updated for commit cd2f60b): https://taiga-ui--pr5872-icon-6p9vimtl.web.app (expires Thu, 09 Nov 2023 09:41:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
BundleMonFiles updated (2)
Unchanged files (4)
Total files change +190B +0.03% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov Report
@@ Coverage Diff @@
## main #5872 +/- ##
=======================================
Coverage 71.93% 71.93%
=======================================
Files 1462 1462
Lines 15964 15964
Branches 2261 2261
=======================================
Hits 11483 11483
Misses 4111 4111
Partials 370 370
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
projects/demo/src/modules/experimental/icon/examples/import/insert-template.md
Outdated
Show resolved
Hide resolved
heading="Two colors" | ||
[content]="example3" | ||
> | ||
<tui-notification class="tui-space_bottom-4">This example only works in modern browsers</tui-notification> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add link to Can i use
?
<tui-notification class="tui-space_bottom-4">This example only works in modern browsers</tui-notification> | |
<tui-notification class="tui-space_bottom-4">This example only works in <a tuiLink href="https://caniuse.com/?search=mask-mode">modern browsers</a></tui-notification> |
I think this example can cause many questions from our users (chrome is modern browser but it does not support this feature)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we hide this example if it does not support this feature ?
Something like the following:
@supports not (mask-mode: luminance) {
.example {
display: none;
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. I believe Chrome 120 actually should support it, even though it is not mentioned on caniuse. It comes out in a month, we'll see :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, tested in Canary, it will work starting next major version.
PR Type
What kind of change does this PR introduce?
What is the current behaviour?
Closes #
What is the new behaviour?