Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): Icon add new component #5872

Merged
merged 3 commits into from
Nov 8, 2023
Merged

feat(experimental): Icon add new component #5872

merged 3 commits into from
Nov 8, 2023

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes #

What is the new behaviour?

Copy link

lumberjack-bot bot commented Nov 7, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Visit the preview URL for this PR (updated for commit cd2f60b):

https://taiga-ui--pr5872-icon-6p9vimtl.web.app

(expires Thu, 09 Nov 2023 09:41:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Nov 7, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/runtime.(hash).js
39.63KB (+152B +0.38%) +10%
demo/browser/main.(hash).js
340.06KB (+38B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.77KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +190B +0.03%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.24MB (+4.62KB +0.2%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #5872 (cd2f60b) into main (0ba65da) will not change coverage.
Report is 8 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5872   +/-   ##
=======================================
  Coverage   71.93%   71.93%           
=======================================
  Files        1462     1462           
  Lines       15964    15964           
  Branches     2261     2261           
=======================================
  Hits        11483    11483           
  Misses       4111     4111           
  Partials      370      370           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 59.66% <ø> (ø)
addon-mobile 60.80% <ø> (ø)
addon-table 60.63% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.65% <ø> (ø)
core 77.97% <ø> (ø)
kit 70.10% <ø> (ø)
summary 71.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

heading="Two colors"
[content]="example3"
>
<tui-notification class="tui-space_bottom-4">This example only works in modern browsers</tui-notification>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add link to Can i use?

Suggested change
<tui-notification class="tui-space_bottom-4">This example only works in modern browsers</tui-notification>
<tui-notification class="tui-space_bottom-4">This example only works in <a tuiLink href="https://caniuse.com/?search=mask-mode">modern browsers</a></tui-notification>

I think this example can cause many questions from our users (chrome is modern browser but it does not support this feature)?

Copy link
Member

@nsbarsukov nsbarsukov Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we hide this example if it does not support this feature ?

Something like the following:

@supports not (mask-mode: luminance) {
    .example {
        display: none;
    }
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I believe Chrome 120 actually should support it, even though it is not mentioned on caniuse. It comes out in a month, we'll see :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, tested in Canary, it will work starting next major version.

@waterplea waterplea merged commit 6b278eb into main Nov 8, 2023
32 of 33 checks passed
@waterplea waterplea deleted the icon branch November 8, 2023 10:58
AtharvChandratre pushed a commit to AtharvChandratre/taiga-ui that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants