Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(demo): improve icons demonstration #5860

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

Copy link

lumberjack-bot bot commented Nov 7, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

bundlemon bot commented Nov 7, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
341.02KB (-17B 0%) +10%
Unchanged files (5)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.91KB +10%
demo/browser/runtime.(hash).js
39.47KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change -21B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.24MB (-26B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Visit the preview URL for this PR (updated for commit ac0ccc5):

https://taiga-ui--pr5860-splincode-ci-icons-z3pr7c36.web.app

(expires Wed, 08 Nov 2023 11:14:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #5860 (ac0ccc5) into main (5a1e81f) will not change coverage.
Report is 6 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5860   +/-   ##
=======================================
  Coverage   71.92%   71.92%           
=======================================
  Files        1462     1462           
  Lines       15962    15962           
  Branches     2261     2261           
=======================================
  Hits        11481    11481           
  Misses       4111     4111           
  Partials      370      370           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 59.66% <ø> (ø)
addon-mobile 60.80% <ø> (ø)
addon-table 60.63% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.65% <ø> (ø)
core 77.96% <ø> (ø)
kit 70.10% <ø> (ø)
summary 71.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ts/cdk/directives/for-async/for-async.directive.ts 100.00% <ø> (ø)
...jects/cdk/directives/for-async/for-async.module.ts 100.00% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's just not remove them when they go out of the viewport.

@splincode
Copy link
Member Author

let's just not remove them when they go out of the viewport.

what do you mean?(

@waterplea
Copy link
Collaborator

let's just not remove them when they go out of the viewport.

what do you mean?(

I mean only set them to true once they intersect and keep them true, do not switch to false when it goes away from the viewport.

@splincode
Copy link
Member Author

do not switch to false when it goes away from the viewport.
Due to the large number of DOM elements, the page begins to slow down

I tested it in the proprietary version

@splincode splincode force-pushed the splincode/ci-icons branch 2 times, most recently from 684981b to f2dd5b7 Compare November 7, 2023 10:59
@splincode splincode merged commit 0ba65da into main Nov 7, 2023
33 checks passed
@splincode splincode deleted the splincode/ci-icons branch November 7, 2023 11:46
AtharvChandratre pushed a commit to AtharvChandratre/taiga-ui that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants