Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): adds harness for dialog #5785

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

Frequency21
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Partially implements #476

What is the new behaviour?

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 27, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Oct 27, 2023

BundleMon

Unchanged files (6)
Status Path Size Limits
demo/browser/main.(hash).js
338.96KB +10%
demo/browser/vendor.(hash).js
201.03KB +10%
demo/browser/runtime.(hash).js
38.71KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +3B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.23MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #5785 (a004ba9) into main (32b660a) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5785   +/-   ##
=======================================
  Coverage   72.33%   72.33%           
=======================================
  Files        1455     1455           
  Lines       15827    15827           
  Branches     2224     2224           
=======================================
  Hits        11449    11449           
  Misses       4017     4017           
  Partials      361      361           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 60.53% <ø> (ø)
addon-mobile 61.25% <ø> (ø)
addon-table 60.63% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.71% <ø> (ø)
core 77.96% <ø> (ø)
kit 70.88% <ø> (ø)
summary 72.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vladimirpotekhin vladimirpotekhin merged commit eed5765 into taiga-family:main Oct 30, 2023
33 checks passed
@Frequency21 Frequency21 deleted the 476-dialog-harness branch October 30, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants