Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-doc): support icons inside menu #5437

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the new behavior?

image image

@lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 20, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Visit the preview URL for this PR (updated for commit 07e41d1):

https://taiga-ui--pr5437-splincode-feat-addon-ypdkihe6.web.app

(expires Thu, 21 Sep 2023 10:42:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@splincode splincode force-pushed the splincode/feat/addon-doc-icons branch from 4be4844 to cdf977a Compare September 20, 2023 10:13
@bundlemon
Copy link

bundlemon bot commented Sep 20, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
332.25KB (+171B +0.05%) +10%
Unchanged files (5)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.86KB +10%
demo/browser/runtime.(hash).js
37.41KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +171B +0.03%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.14MB (+171B +0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode force-pushed the splincode/feat/addon-doc-icons branch from cdf977a to 0b82cc3 Compare September 20, 2023 10:33
@splincode splincode force-pushed the splincode/feat/addon-doc-icons branch from 0b82cc3 to 07e41d1 Compare September 20, 2023 10:38
@splincode splincode requested a review from waterplea September 20, 2023 10:38
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #5437 (07e41d1) into main (2921a21) will increase coverage by 1.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5437      +/-   ##
==========================================
+ Coverage   71.26%   72.70%   +1.43%     
==========================================
  Files         695     1438     +743     
  Lines        6554    15634    +9080     
  Branches      805     2186    +1381     
==========================================
+ Hits         4671    11367    +6696     
- Misses       1767     3911    +2144     
- Partials      116      356     +240     
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 60.38% <ø> (ø)
addon-mobile 61.32% <ø> (ø)
addon-table 61.01% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 80.13% <ø> (ø)
core 78.58% <ø> (?)
kit 70.96% <ø> (?)
summary 72.70% <ø> (+1.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
projects/addon-doc/interfaces/page.ts 100.00% <ø> (ø)

... and 743 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@splincode splincode merged commit c0eef53 into main Sep 20, 2023
@splincode splincode deleted the splincode/feat/addon-doc-icons branch September 20, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants