Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-mobile): remove shadow background in mobile calendar header #5326

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #4025

image

What is the new behavior?

image image

@lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 8, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Sep 8, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
331.43KB (-117B -0.03%) +10%
Unchanged files (5)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.83KB +10%
demo/browser/runtime.(hash).js
36.75KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change -117B -0.02%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.11MB (-117B -0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Visit the preview URL for this PR (updated for commit 1ea123a):

https://taiga-ui--pr5326-splincode-fix-issues-5wz04o3b.web.app

(expires Tue, 12 Sep 2023 09:12:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #5326 (1ea123a) into main (e684bdc) will decrease coverage by 7.55%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5326      +/-   ##
==========================================
- Coverage   72.31%   64.76%   -7.55%     
==========================================
  Files        1437      291    -1146     
  Lines       15617     3221   -12396     
  Branches     2194      356    -1838     
==========================================
- Hits        11293     2086    -9207     
+ Misses       3964     1081    -2883     
+ Partials      360       54     -306     
Flag Coverage Δ
addon-charts 71.16% <ø> (ø)
addon-doc 60.45% <ø> (ø)
addon-mobile 61.32% <ø> (ø)
addon-table ?
addon-tablebars ?
cdk ?
core ?
kit ?
summary 64.76% <ø> (-7.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1146 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@splincode splincode force-pushed the splincode/fix/issues/4025 branch from f6f886e to d5ef4fb Compare September 8, 2023 12:49
@splincode splincode force-pushed the splincode/fix/issues/4025 branch from d5ef4fb to 1ea123a Compare September 11, 2023 09:03
@splincode splincode merged commit c174365 into main Sep 11, 2023
@splincode splincode deleted the splincode/fix/issues/4025 branch September 11, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - mobile calendar - not consistent color
4 participants