Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): add new component Badge #5247

Merged
merged 6 commits into from
Sep 14, 2023
Merged

feat(experimental): add new component Badge #5247

merged 6 commits into from
Sep 14, 2023

Conversation

vladimirpotekhin
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

@bundlemon
Copy link

bundlemon bot commented Aug 30, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/runtime.(hash).js
37.01KB (+289B +0.77%) +10%
demo/browser/main.(hash).js
332.02KB (+92B +0.03%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.84KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +381B +0.06%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.12MB (+9.8KB +0.45%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

Visit the preview URL for this PR (updated for commit 2ddeff8):

https://taiga-ui--pr5247-badge-yos2x4va.web.app

(expires Thu, 14 Sep 2023 15:22:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 30, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #5247 (2ddeff8) into main (6fab20c) will increase coverage by 0.32%.
Report is 35 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5247      +/-   ##
==========================================
+ Coverage   72.31%   72.63%   +0.32%     
==========================================
  Files        1437     1438       +1     
  Lines       15617    15628      +11     
  Branches     2194     2197       +3     
==========================================
+ Hits        11293    11352      +59     
+ Misses       3964     3917      -47     
+ Partials      360      359       -1     
Flag Coverage Δ
addon-charts 71.13% <ø> (-0.04%) ⬇️
addon-doc 60.45% <ø> (ø)
addon-mobile 61.32% <ø> (ø)
addon-table 61.01% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 79.87% <ø> (-0.05%) ⬇️
core 78.54% <100.00%> (+1.58%) ⬆️
kit 70.92% <ø> (-0.01%) ⬇️
summary 72.63% <100.00%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
projects/core/animations/animations.ts 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vladimirpotekhin vladimirpotekhin force-pushed the badge branch 2 times, most recently from 3cc73a3 to 3f778a3 Compare September 1, 2023 14:14
projects/experimental/components/badge/badge.style.less Outdated Show resolved Hide resolved
projects/experimental/components/badge/badge.style.less Outdated Show resolved Hide resolved
projects/experimental/components/badge/badge.style.less Outdated Show resolved Hide resolved
projects/experimental/components/badge/badge.style.less Outdated Show resolved Hide resolved
projects/experimental/components/badge/badge.style.less Outdated Show resolved Hide resolved
projects/experimental/components/badge/badge.template.html Outdated Show resolved Hide resolved
projects/experimental/components/badge/badge.template.html Outdated Show resolved Hide resolved
projects/experimental/types/badge-appearance.ts Outdated Show resolved Hide resolved
projects/experimental/components/badge/badge.component.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: Oops, saw the example I asked for.

projects/experimental/components/badge/badge.component.ts Outdated Show resolved Hide resolved
projects/experimental/components/badge/badge.component.ts Outdated Show resolved Hide resolved
projects/experimental/components/badge/badge.component.ts Outdated Show resolved Hide resolved
projects/experimental/components/badge/badge.template.html Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants