Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): Fade add new component #5169

Merged
merged 3 commits into from
Aug 24, 2023
Merged

feat(experimental): Fade add new component #5169

merged 3 commits into from
Aug 24, 2023

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

@lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 22, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Aug 22, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/runtime.(hash).js
36.51KB (+182B +0.49%) +10%
demo/browser/main.(hash).js
330.51KB (+49B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.63KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +231B +0.04%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.1MB (+6.42KB +0.3%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

Visit the preview URL for this PR (updated for commit 785b6cd):

https://taiga-ui--pr5169-fade-ze51jnwz.web.app

(expires Thu, 24 Aug 2023 19:42:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #5169 (785b6cd) into main (7d60853) will not change coverage.
Report is 5 commits behind head on main.
The diff coverage is 30.30%.

@@           Coverage Diff           @@
##             main    #5169   +/-   ##
=======================================
  Coverage   72.40%   72.40%           
=======================================
  Files        1430     1430           
  Lines       15522    15522           
  Branches     2181     2181           
=======================================
  Hits        11239    11239           
  Misses       3928     3928           
  Partials      355      355           
Flag Coverage Δ
addon-charts 70.92% <0.00%> (ø)
addon-doc 60.45% <ø> (ø)
addon-mobile 61.28% <14.28%> (ø)
addon-table 61.01% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 80.07% <57.14%> (ø)
core 76.89% <33.33%> (ø)
kit 71.24% <0.00%> (ø)
summary 72.40% <30.30%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...components/line-chart/line-chart-hint.directive.ts 24.24% <0.00%> (ø)
...arts/components/line-chart/line-chart.component.ts 18.03% <0.00%> (ø)
.../line-days-chart/line-days-chart-hint.directive.ts 28.57% <0.00%> (ø)
...nents/line-days-chart/line-days-chart.component.ts 13.51% <0.00%> (ø)
...charts/components/pie-chart/pie-chart.directive.ts 75.00% <ø> (ø)
...nents/pull-to-refresh/pull-to-refresh.component.ts 36.00% <ø> (ø)
.../sheet/components/sheet-bar/sheet-bar.component.ts 53.84% <0.00%> (ø)
...mponents/sheet/components/sheet/sheet.component.ts 34.21% <0.00%> (ø)
...mponents/sheet/components/sheet/sheet.providers.ts 71.42% <ø> (ø)
...et/directives/sheet-close/sheet-close.directive.ts 42.85% <0.00%> (ø)
... and 23 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@splincode
Copy link
Member

@n-barsukov
image

@n-barsukov
Copy link
Contributor

@n-barsukov image

@splincode
It is expected because next application doesn't have this new page:

https://taiga-ui.dev/next/experimental/fade

@splincode splincode merged commit 4f36897 into main Aug 24, 2023
@splincode splincode deleted the fade branch August 24, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants