Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): clear cache string when checking source path is url path #4623

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jun 9, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Jun 9, 2023

BundleMon

Unchanged files (6)
Status Path Size Limits
demo/browser/main.(hash).js
326.08KB +10%
demo/browser/vendor.(hash).js
199.94KB +10%
demo/browser/runtime.(hash).js
37.86KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +3B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.25MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Visit the preview URL for this PR (updated for commit 1289462):

https://taiga-ui--pr4623-splincode-fix-propri-aaucia7y.web.app

(expires Sat, 10 Jun 2023 09:35:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.92 ⚠️

Comparison is base (37e51dd) 69.99% compared to head (cbf2e5f) 69.07%.

❗ Current head cbf2e5f differs from pull request most recent head 1289462. Consider uploading reports for the commit 1289462 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4623      +/-   ##
==========================================
- Coverage   69.99%   69.07%   -0.92%     
==========================================
  Files        1574     1144     -430     
  Lines       17248    11574    -5674     
  Branches     2413     1531     -882     
==========================================
- Hits        12072     7995    -4077     
+ Misses       4785     3330    -1455     
+ Partials      391      249     -142     
Flag Coverage Δ
addon-charts 71.53% <ø> (ø)
addon-doc 59.80% <ø> (ø)
addon-editor 49.28% <ø> (ø)
addon-mobile 61.31% <ø> (ø)
addon-table 61.19% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 80.95% <ø> (ø)
core 77.06% <100.00%> (+<0.01%) ⬆️
kit ?
summary 69.07% <100.00%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/core/components/svg/svg.component.ts 95.83% <100.00%> (+0.05%) ⬆️

... and 430 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode force-pushed the splincode/fix/proprietary-icons branch from cbf2e5f to 1289462 Compare June 9, 2023 09:27
@splincode splincode merged commit ec65348 into main Jun 9, 2023
@splincode splincode deleted the splincode/fix/proprietary-icons branch June 9, 2023 09:29
@well-done-bot
Copy link

well-done-bot bot commented Jun 9, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants