Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-editor): immediately unsubscribe streams when toolbar is destroyed #4588

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jun 5, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode splincode force-pushed the splincode/fix/addon-editor branch from b60dfd4 to 5625303 Compare June 5, 2023 10:28
@splincode splincode changed the title Splincode/fix/addon editor fix(addon-editor): immediately unsubscribe streams when toolbar is destroyed Jun 5, 2023
@bundlemon
Copy link

bundlemon bot commented Jun 5, 2023

BundleMon

Unchanged files (6)
Status Path Size Limits
demo/browser/main.(hash).js
325.95KB +10%
demo/browser/vendor.(hash).js
199KB +10%
demo/browser/runtime.(hash).js
37.86KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change -1B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.24MB (+37B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Visit the preview URL for this PR (updated for commit 5625303):

https://taiga-ui--pr4588-splincode-fix-addon-j25mpqxi.web.app

(expires Tue, 06 Jun 2023 10:35:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.01 ⚠️

Comparison is base (2b94f6f) 70.07% compared to head (5625303) 70.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4588      +/-   ##
==========================================
- Coverage   70.07%   70.07%   -0.01%     
==========================================
  Files        1574     1574              
  Lines       17221    17222       +1     
  Branches     2404     2404              
==========================================
  Hits        12068    12068              
- Misses       4765     4766       +1     
  Partials      388      388              
Flag Coverage Δ
addon-charts 71.53% <ø> (ø)
addon-doc 59.80% <ø> (ø)
addon-editor 49.73% <33.33%> (-0.03%) ⬇️
addon-mobile 61.31% <ø> (ø)
addon-table 61.19% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 80.95% <ø> (ø)
core 77.08% <ø> (ø)
kit 71.85% <ø> (ø)
summary 70.07% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...don-editor/components/toolbar/toolbar.component.ts 11.82% <33.33%> (-0.13%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode merged commit db84ded into main Jun 5, 2023
@splincode splincode deleted the splincode/fix/addon-editor branch June 5, 2023 12:12
@well-done-bot
Copy link

well-done-bot bot commented Jun 5, 2023

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants