Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): InputDateRange fix showing same month twice when min is later than given month #4569

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #4544

What is the new behavior?

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jun 1, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Jun 1, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
326.06KB (+24B +0.01%) +10%
Unchanged files (5)
Status Path Size Limits
demo/browser/vendor.(hash).js
198.99KB +10%
demo/browser/runtime.(hash).js
37.86KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +24B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.24MB (+24B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Visit the preview URL for this PR (updated for commit 6370258):

https://taiga-ui--pr4569-calendar-wqvhfz4i.web.app

(expires Fri, 02 Jun 2023 05:11:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (54c8177) 70.08% compared to head (6370258) 70.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4569   +/-   ##
=======================================
  Coverage   70.08%   70.08%           
=======================================
  Files        1570     1570           
  Lines       17204    17204           
  Branches     2419     2419           
=======================================
  Hits        12057    12057           
  Misses       4753     4753           
  Partials      394      394           
Flag Coverage Δ
addon-charts 71.41% <ø> (ø)
addon-doc 59.80% <ø> (ø)
addon-editor 49.75% <ø> (ø)
addon-mobile 62.13% <ø> (ø)
addon-table 61.19% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 81.30% <ø> (ø)
core 76.81% <ø> (ø)
kit 71.74% <ø> (ø)
summary 70.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vladimirpotekhin
Copy link
Member

@vladimirpotekhin
Copy link
Member

something is wrong when default view month is selected

https://taiga-ui--pr4569-calendar-wqvhfz4i.web.app/components/input-date-range/API?defaultViewedMonth$=2&min$=2&max$=4

oh sorry, its reproduced on main. probably a separate bug

@waterplea waterplea merged commit 0573b29 into main Jun 1, 2023
@waterplea waterplea deleted the calendar branch June 1, 2023 09:21
@well-done-bot
Copy link

well-done-bot bot commented Jun 1, 2023

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants