Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): schematics fix global-styles migration #3797

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

vladimirpotekhin
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Mar 3, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Mar 3, 2023

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
338.96KB +10%
demo/browser/vendor.(hash).js
204.37KB +10%
demo/browser/runtime.(hash).js
36.1KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
18.08KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.3MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

Visit the preview URL for this PR (updated for commit 0c7db8a):

https://taiga-ui--pr3797-schematic-fix-j9kjvdzu.web.app

(expires Sat, 04 Mar 2023 10:00:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e153079) 61.31% compared to head (0c7db8a) 61.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3797   +/-   ##
=======================================
  Coverage   61.31%   61.31%           
=======================================
  Files        1578     1578           
  Lines       18675    18675           
  Branches     2581     2581           
=======================================
  Hits        11450    11450           
  Misses       6751     6751           
  Partials      474      474           
Flag Coverage Δ
addon-charts 72.01% <ø> (ø)
addon-doc 49.76% <ø> (ø)
addon-editor 49.58% <ø> (ø)
addon-mobile 61.77% <ø> (ø)
addon-table 60.21% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 40.32% <ø> (ø)
core 76.97% <ø> (ø)
kit 72.98% <ø> (ø)
summary 61.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dk/schematics/ng-update/v3/steps/replace-styles.ts 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode merged commit 21cc5fa into main Mar 6, 2023
@splincode splincode deleted the schematic-fix branch March 6, 2023 07:58
@well-done-bot
Copy link

well-done-bot bot commented Mar 6, 2023

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants