-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): TUI_VIEWPORT
add new token
#3617
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonFiles updated (2)
Unchanged files (3)
Total files change +129B +0.02% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Visit the preview URL for this PR (updated for commit 15d9e38): https://taiga-ui--pr3617-viewport-6tvopqoh.web.app (expires Wed, 08 Feb 2023 12:11:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
Codecov ReportBase: 61.18% // Head: 61.18% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3617 +/- ##
=======================================
Coverage 61.18% 61.18%
=======================================
Files 1562 1563 +1
Lines 18454 18467 +13
Branches 2556 2556
=======================================
+ Hits 11291 11299 +8
- Misses 6690 6695 +5
Partials 473 473
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@waterplea Now I understand what happens at the time of the screenshot on cypress and why screenshots can sometimes behave this way Screen.Recording.2023-02-08.at.10.12.13.mov |
But aren't we disabling animations for Cypress? |
Screen.Recording.2023-02-08.at.17.50.33.movScreen.Recording.2023-02-08.at.17.51.28.mov |
Maybe we should also set hide delay to 0. |
@waterplea |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3540
What is the new behavior?
Does this PR introduce a breaking change?