Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): TUI_VIEWPORT add new token #3617

Merged
merged 1 commit into from
Feb 9, 2023
Merged

feat(core): TUI_VIEWPORT add new token #3617

merged 1 commit into from
Feb 9, 2023

Conversation

waterplea
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3540

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Feb 7, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Feb 7, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
334.72KB (+141B +0.04%) +10%
demo/browser/runtime.(hash).js
35.42KB (-12B -0.03%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
203.32KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
18.08KB +10%

Total files change +129B +0.02%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.26MB (+187B +0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Visit the preview URL for this PR (updated for commit 15d9e38):

https://taiga-ui--pr3617-viewport-6tvopqoh.web.app

(expires Wed, 08 Feb 2023 12:11:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 61.18% // Head: 61.18% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (15d9e38) compared to base (1be6586).
Patch coverage: 61.53% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3617   +/-   ##
=======================================
  Coverage   61.18%   61.18%           
=======================================
  Files        1562     1563    +1     
  Lines       18454    18467   +13     
  Branches     2556     2556           
=======================================
+ Hits        11291    11299    +8     
- Misses       6690     6695    +5     
  Partials      473      473           
Flag Coverage Δ
addon-charts 71.99% <ø> (ø)
addon-doc 49.76% <ø> (ø)
addon-editor 50.12% <50.00%> (-0.06%) ⬇️
addon-mobile 61.77% <ø> (ø)
addon-table 60.61% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 40.32% <ø> (ø)
core 76.61% <65.00%> (+<0.01%) ⬆️
kit 72.89% <ø> (ø)
summary 61.18% <61.53%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/core/abstract/rect-accessor.ts 100.00% <ø> (ø)
...omponents/editor/portal/editor-portal.directive.ts 62.50% <50.00%> (-37.50%) ⬇️
...directives/dropdown/dropdown-position.directive.ts 36.36% <50.00%> (ø)
...ts/core/directives/hint/hint-position.directive.ts 32.07% <50.00%> (ø)
...ives/dropdown/dropdown-position-sided.directive.ts 44.82% <66.66%> (ø)
projects/core/tokens/viewport.ts 75.00% <75.00%> (ø)
projects/core/tokens/index.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode
Copy link
Member

is this the expected behavior?

image

image

@waterplea
Copy link
Collaborator Author

is this the expected behavior?

image image

Kind of. There's no better way for this dropdown to show, editor is too short. As for the top image, do you know why there's border instead of margin? Margin seems to behave the same, at a glance, and dropdown switches to down at the correct moment.

@splincode
Copy link
Member

splincode commented Feb 8, 2023

@waterplea Now I understand what happens at the time of the screenshot on cypress and why screenshots can sometimes behave this way

Screen.Recording.2023-02-08.at.10.12.13.mov

@waterplea
Copy link
Collaborator Author

@waterplea Now I understand what happens at the time of the screenshot on cypress and why screenshots can sometimes behave this way

Screen.Recording.2023-02-08.at.10.12.13.mov

But aren't we disabling animations for Cypress?

@splincode
Copy link
Member

But aren't we disabling animations for Cypress? you are right

Screen.Recording.2023-02-08.at.17.50.33.mov
Screen.Recording.2023-02-08.at.17.51.28.mov

@waterplea
Copy link
Collaborator Author

But aren't we disabling animations for Cypress? you are right

Maybe we should also set hide delay to 0.

@waterplea waterplea merged commit a0093a0 into main Feb 9, 2023
@waterplea waterplea deleted the viewport branch February 9, 2023 05:56
@well-done-bot
Copy link

well-done-bot bot commented Feb 9, 2023

'Well done'

@splincode
Copy link
Member

@waterplea Maybe we should also set hide delay to 0.

#3643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Data list items truncated when window scale isn't equal 100%
3 participants