Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): MultiSelect fix dropdown for various updateOn options #3479

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

waterplea
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jan 23, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023

Visit the preview URL for this PR (updated for commit 5ab2c8b):

https://taiga-ui--pr3479-update-on-2dfwwkqq.web.app

(expires Tue, 24 Jan 2023 09:36:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented Jan 23, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
333.17KB (-41B -0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
204.87KB +10%
demo/browser/runtime.(hash).js
34.81KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change -41B -0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.22MB (-41B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 61.30% // Head: 61.32% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (5ab2c8b) compared to base (592ad35).
Patch coverage: 76.92% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3479      +/-   ##
==========================================
+ Coverage   61.30%   61.32%   +0.01%     
==========================================
  Files        1537     1537              
  Lines       18248    18249       +1     
  Branches     2547     2545       -2     
==========================================
+ Hits        11187    11191       +4     
+ Misses       6593     6591       -2     
+ Partials      468      467       -1     
Flag Coverage Δ
addon-charts 72.34% <ø> (ø)
addon-doc 49.81% <ø> (ø)
addon-editor 50.40% <ø> (ø)
addon-mobile 61.73% <ø> (ø)
addon-table 60.61% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 40.31% <ø> (ø)
core 76.83% <ø> (ø)
kit 72.91% <76.92%> (+0.06%) ⬆️
summary 61.32% <76.92%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lti-select-option/multi-select-option.component.ts 40.00% <50.00%> (+6.66%) ⬆️
.../components/multi-select/multi-select.component.ts 77.02% <50.00%> (ø)
...omponents/select-option/select-option.component.ts 96.42% <87.50%> (+4.42%) ⬆️
...ts/kit/components/combo-box/combo-box.component.ts 61.76% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waterplea waterplea merged commit 554c519 into main Jan 23, 2023
@waterplea waterplea deleted the update-on branch January 23, 2023 17:27
@well-done-bot
Copy link

well-done-bot bot commented Jan 23, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants