Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tslib should be a transitive dependency from @taiga/cdk #3430

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

WARNING in [DedupeModuleResolvePlugin]: /builds/prm/prm-ui/node_modules/@taiga-ui/cdk/node_modules/tslib/tslib.es6.js -> /builds/prm/prm-ui/node_modules/@taiga-ui/addon-tablebars/node_modules/tslib/tslib.es6.js
Error: [DedupeModuleResolvePlugin]: /builds/prm/prm-ui/node_modules/@taiga-ui/cdk/node_modules/tslib/tslib.es6.js -> /builds/prm/prm-ui/node_modules/@taiga-ui/addon-tablebars/node_modules/tslib/tslib.es6.js
    at addWarning (/builds/prm/prm-ui/node_modules/@angular-devkit/build-angular/src/utils/webpack-diagnostics.js:13:31)
    at /builds/prm/prm-ui/node_modules/@angular-devkit/build-angular/src/webpack/plugins/dedupe-module-resolve-plugin.js:65:58
    at Hook.eval [as callAsync] (eval at create (/builds/prm/prm-ui/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:22:16)
    at /builds/prm/prm-ui/node_modules/webpack/lib/NormalModuleFactory.js:284:30
    at eval (eval at create (/builds/prm/prm-ui/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
    at /builds/prm/prm-ui/node_modules/webpack/lib/NormalModuleFactory.js:591:7
    at /builds/prm/prm-ui/node_modules/webpack/lib/NormalModuleFactory.js:116:11
    at /builds/prm/prm-ui/node_modules/webpack/lib/NormalModuleFactory.js:623:8
    at NormalModuleFactory.resolveRequestArray (/builds/prm/prm-ui/node_modules/webpack/lib/NormalModuleFactory.js:988:34)
    at /builds/prm/prm-ui/node_modules/webpack/lib/NormalModuleFactory.js:615:11
    at /builds/prm/prm-ui/node_modules/webpack/lib/NormalModuleFactory.js:116:11
    at /builds/prm/prm-ui/node_modules/webpack/lib/NormalModuleFactory.js:678:9
    at /builds/prm/prm-ui/node_modules/webpack/lib/NormalModuleFactory.js:859:5
    at finishResolved (/builds/prm/prm-ui/node_modules/enhanced-resolve/lib/Resolver.js:294:11)
    at /builds/prm/prm-ui/node_modules/enhanced-resolve/lib/Resolver.js:362:25
    at /builds/prm/prm-ui/node_modules/enhanced-resolve/lib/Resolver.js:434:24

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jan 15, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Jan 15, 2023

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
332.78KB +10%
demo/browser/vendor.(hash).js
205.04KB +10%
demo/browser/runtime.(hash).js
34.71KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.21MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 7e225d6):

https://taiga-ui--pr3430-splincode-feat-tslib-s4olv1fw.web.app

(expires Mon, 16 Jan 2023 19:51:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 61.30% // Head: 61.30% // No change to project coverage 👍

Coverage data is based on head (7e225d6) compared to base (4b799b5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3430   +/-   ##
=======================================
  Coverage   61.30%   61.30%           
=======================================
  Files        1535     1535           
  Lines       18163    18163           
  Branches     2543     2543           
=======================================
  Hits        11134    11134           
  Misses       6560     6560           
  Partials      469      469           
Flag Coverage Δ
addon-charts 72.46% <ø> (ø)
addon-doc 50.00% <ø> (ø)
addon-editor 50.34% <ø> (ø)
addon-mobile 62.31% <ø> (ø)
addon-table 60.79% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 39.90% <ø> (ø)
core 76.84% <ø> (ø)
kit 72.90% <ø> (ø)
summary 61.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode merged commit abc5323 into main Jan 16, 2023
@splincode splincode deleted the splincode/feat/tslib branch January 16, 2023 10:45
@well-done-bot
Copy link

well-done-bot bot commented Jan 16, 2023

'Well done'

splincode added a commit that referenced this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants