feat(addon-table): add directive to sort by order #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarghamkhandev
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin and
nsbarsukov
as code owners
splincode
approved these changes
Oct 2, 2022
waterplea
approved these changes
Oct 3, 2022
Codecov ReportBase: 56.27% // Head: 39.78% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2782 +/- ##
===========================================
- Coverage 56.27% 39.78% -16.49%
===========================================
Files 956 986 +30
Lines 9237 9451 +214
Branches 1894 1919 +25
===========================================
- Hits 5198 3760 -1438
- Misses 3623 5487 +1864
+ Partials 416 204 -212
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@zarghamkhandev you forgot to add it to |
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
|
fixed ✅ @waterplea |
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
To specify sort direction one needs to pass direction as 1 or -1 which is a bit confusing.
Closes # #2266
What is the new behavior?
Allows user to specify direction in terms of order e.g "asc" or "desc" instead of 1 or -1.
Does this PR introduce a breaking change?