Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): InputDateRange navigate months in sync, cancel unfinished range on esc #2647

Merged
merged 5 commits into from
Sep 12, 2022

Conversation

vladimirpotekhin
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #2454

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 8, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Visit the preview URL for this PR (updated for commit 232bdfa):

https://taiga-ui--pr2647-calendar-range-1jpnfae0.web.app

(expires Tue, 13 Sep 2022 08:00:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #2647 (232bdfa) into main (41c9ec3) will decrease coverage by 0.01%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##             main    #2647      +/-   ##
==========================================
- Coverage   56.70%   56.69%   -0.02%     
==========================================
  Files         955      955              
  Lines        9233     9232       -1     
  Branches     1897     1894       -3     
==========================================
- Hits         5236     5234       -2     
  Misses       3587     3587              
- Partials      410      411       +1     
Flag Coverage Δ
addon-charts 73.64% <ø> (ø)
addon-doc 19.16% <ø> (ø)
addon-editor 28.82% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 62.87% <ø> (ø)
core 62.86% <ø> (ø)
kit 61.54% <44.44%> (-0.04%) ⬇️
summary 56.69% <44.44%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lendar-range/primitive-calendar-range.component.ts 88.88% <33.33%> (+2.88%) ⬆️
...ponents/calendar-range/calendar-range.component.ts 70.17% <50.00%> (-3.41%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vladimirpotekhin vladimirpotekhin marked this pull request as ready for review September 9, 2022 08:04
@splincode splincode merged commit 14f2907 into main Sep 12, 2022
@splincode splincode deleted the calendar-range branch September 12, 2022 08:55
@well-done-bot
Copy link

well-done-bot bot commented Sep 12, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🚀 - CalendarRange
4 participants