-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Hint support 12 directions #2256
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Visit the preview URL for this PR (updated for commit 6abf063): https://taiga-ui--pr2256-hints-54zgi743.web.app (expires Thu, 04 Aug 2022 09:59:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Codecov Report
@@ Coverage Diff @@
## v3.x #2256 +/- ##
==========================================
+ Coverage 56.57% 56.62% +0.04%
==========================================
Files 966 973 +7
Lines 9718 9622 -96
Branches 1975 1951 -24
==========================================
- Hits 5498 5448 -50
+ Misses 3788 3743 -45
+ Partials 432 431 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
projects/addon-charts/components/line-days-chart/line-days-chart-hint.directive.ts
Outdated
Show resolved
Hide resolved
selector: `[tuiHint]`, | ||
providers: [TuiDestroyService], | ||
}) | ||
export class TuiHintDriverDirective extends AbstractTuiDriverDirective {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we explicitly extends this class by all "drivers" ?
It was difficult for me to realize when we subscribe to all "drivers"-observables :(
Now I understand that it happens here but it is not obvious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is we have a driver and we have a vehicle. To connect them together we need to inject and subscribe. And to initiate this action we need a directive with a particular selector. But the action is always the same so I moved it into abstract directive. Basically, for every pair of driver/vehicle we will have a directive like that which is only necessary for its selector and the work it does is the same and happens in abstract class.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #699
Closes #739
Closes #1258
What is the new behavior?
Does this PR introduce a breaking change?