Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Hint support 12 directions #2256

Merged
merged 1 commit into from
Aug 3, 2022
Merged

feat(core): Hint support 12 directions #2256

merged 1 commit into from
Aug 3, 2022

Conversation

waterplea
Copy link
Collaborator

@waterplea waterplea commented Aug 1, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #699
Closes #739
Closes #1258

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 1, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Visit the preview URL for this PR (updated for commit 6abf063):

https://taiga-ui--pr2256-hints-54zgi743.web.app

(expires Thu, 04 Aug 2022 09:59:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #2256 (fac915d) into v3.x (10ac547) will increase coverage by 0.04%.
The diff coverage is 56.66%.

❗ Current head fac915d differs from pull request most recent head 6abf063. Consider uploading reports for the commit 6abf063 to get more accurate results

@@            Coverage Diff             @@
##             v3.x    #2256      +/-   ##
==========================================
+ Coverage   56.57%   56.62%   +0.04%     
==========================================
  Files         966      973       +7     
  Lines        9718     9622      -96     
  Branches     1975     1951      -24     
==========================================
- Hits         5498     5448      -50     
+ Misses       3788     3743      -45     
+ Partials      432      431       -1     
Flag Coverage Δ
addon-charts 73.67% <100.00%> (+0.12%) ⬆️
addon-doc 18.87% <ø> (ø)
addon-editor 28.96% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 64.75% <ø> (ø)
core 67.15% <56.20%> (+0.75%) ⬆️
kit 58.54% <54.54%> (-0.05%) ⬇️
summary 56.62% <56.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...charts/components/pie-chart/pie-chart.component.ts 75.00% <ø> (ø)
...on-charts/components/pie-chart/pie-chart.module.ts 100.00% <ø> (ø)
...core/components/hints-host/hints-host.component.ts 100.00% <ø> (+20.00%) ⬆️
...ts/core/components/hints-host/hints-host.module.ts 100.00% <ø> (ø)
projects/core/directives/hint/hint-options.ts 100.00% <ø> (ø)
projects/core/directives/hint/hint.module.ts 100.00% <ø> (ø)
.../kit/components/line-clamp/line-clamp.component.ts 14.70% <ø> (ø)
...cts/kit/components/line-clamp/line-clamp.module.ts 100.00% <ø> (ø)
...ts/core/directives/hint/hint-position.directive.ts 23.91% <23.91%> (ø)
...ects/core/directives/hint/hint-manual.directive.ts 25.00% <25.00%> (ø)
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

selector: `[tuiHint]`,
providers: [TuiDestroyService],
})
export class TuiHintDriverDirective extends AbstractTuiDriverDirective {}
Copy link
Member

@nsbarsukov nsbarsukov Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we explicitly extends this class by all "drivers" ?

It was difficult for me to realize when we subscribe to all "drivers"-observables :(
Now I understand that it happens here but it is not obvious.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is we have a driver and we have a vehicle. To connect them together we need to inject and subscribe. And to initiate this action we need a directive with a particular selector. But the action is always the same so I moved it into abstract directive. Basically, for every pair of driver/vehicle we will have a directive like that which is only necessary for its selector and the work it does is the same and happens in abstract class.

@waterplea waterplea deleted the hints branch August 3, 2022 10:49
@well-done-bot
Copy link

well-done-bot bot commented Aug 3, 2022

'Well done'

splincode pushed a commit that referenced this pull request Aug 3, 2022
splincode pushed a commit that referenced this pull request Aug 4, 2022
tinkoff-bot pushed a commit that referenced this pull request Aug 4, 2022
splincode pushed a commit that referenced this pull request Aug 5, 2022
splincode pushed a commit that referenced this pull request Aug 6, 2022
tinkoff-bot pushed a commit that referenced this pull request Aug 8, 2022
tinkoff-bot pushed a commit that referenced this pull request Aug 8, 2022
tinkoff-bot pushed a commit that referenced this pull request Aug 8, 2022
tinkoff-bot pushed a commit that referenced this pull request Aug 8, 2022
splincode pushed a commit that referenced this pull request Aug 9, 2022
tinkoff-bot pushed a commit that referenced this pull request Aug 9, 2022
splincode pushed a commit that referenced this pull request Aug 10, 2022
splincode pushed a commit that referenced this pull request Aug 16, 2022
splincode pushed a commit that referenced this pull request Aug 16, 2022
splincode pushed a commit that referenced this pull request Aug 22, 2022
splincode pushed a commit that referenced this pull request Aug 23, 2022
tinkoff-bot pushed a commit that referenced this pull request Aug 23, 2022
tinkoff-bot pushed a commit that referenced this pull request Aug 23, 2022
tinkoff-bot pushed a commit that referenced this pull request Aug 23, 2022
splincode pushed a commit that referenced this pull request Aug 24, 2022
tinkoff-bot pushed a commit that referenced this pull request Aug 24, 2022
splincode pushed a commit that referenced this pull request Aug 25, 2022
splincode pushed a commit that referenced this pull request Aug 25, 2022
splincode pushed a commit that referenced this pull request Aug 26, 2022
splincode pushed a commit that referenced this pull request Aug 30, 2022
This was referenced Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants