-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove deprecated entities #2108
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Visit the preview URL for this PR (updated for commit abc0334): https://taiga-ui--pr2108-deprecated-stuff-8yqcntc3.web.app (expires Wed, 13 Jul 2022 15:41:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Codecov Report
@@ Coverage Diff @@
## v3.x #2108 +/- ##
==========================================
- Coverage 61.28% 60.48% -0.81%
==========================================
Files 931 922 -9
Lines 9762 9515 -247
Branches 1916 1911 -5
==========================================
- Hits 5983 5755 -228
+ Misses 3334 3316 -18
+ Partials 445 444 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3543456
to
b3eaebf
Compare
b3eaebf
to
fe020f8
Compare
export const TUI_COUNTRIES_MASKS: InjectionToken<Record<TuiCountryIsoCode, string>> = | ||
new InjectionToken<Record<TuiCountryIsoCode, string>>('Countries masks', { | ||
factory: () => COUNTRIES_MASKS, | ||
factory: () => ({ | ||
[TuiCountryIsoCode.AD]: '+376###-###', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember we wanted to move this out to a separate package. @rvalitov, are you still interested in it? @splincode @vladimirpotekhin @nsbarsukov what do you guys think, maybe it's time we move it out? We can at least create a repository and move this constant there so later we can separately maintain this and add some trusted source? See #917
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, should we create repo in tinkoff space or completely separate ?
projects/kit/components/progress/progress-bar/progress-color-segments.directive.ts
Outdated
Show resolved
Hide resolved
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe