Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove deprecated entities #2108

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Conversation

vladimirpotekhin
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 12, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2022

Visit the preview URL for this PR (updated for commit abc0334):

https://taiga-ui--pr2108-deprecated-stuff-8yqcntc3.web.app

(expires Wed, 13 Jul 2022 15:41:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #2108 (abc0334) into v3.x (14e41eb) will decrease coverage by 0.80%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             v3.x    #2108      +/-   ##
==========================================
- Coverage   61.28%   60.48%   -0.81%     
==========================================
  Files         931      922       -9     
  Lines        9762     9515     -247     
  Branches     1916     1911       -5     
==========================================
- Hits         5983     5755     -228     
+ Misses       3334     3316      -18     
+ Partials      445      444       -1     
Flag Coverage Δ
addon-charts 73.96% <ø> (ø)
addon-doc 21.11% <0.00%> (ø)
addon-editor 46.11% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (+4.19%) ⬆️
addon-tablebars ∅ <ø> (∅)
cdk 66.05% <ø> (-0.05%) ⬇️
core 67.39% <100.00%> (+0.07%) ⬆️
kit 58.93% <41.66%> (-1.94%) ⬇️
summary 60.48% <40.00%> (-0.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/addon-commerce/tokens/i18n.ts 100.00% <ø> (ø)
...on-doc/src/components/example/example.component.ts 3.03% <0.00%> (ø)
projects/addon-editor/tokens/i18n.ts 100.00% <ø> (ø)
projects/addon-table/tokens/i18n.ts 100.00% <ø> (ø)
projects/cdk/utils/browser/is-edge-older-than.ts 100.00% <ø> (ø)
projects/cdk/utils/browser/is-ie.ts 100.00% <ø> (ø)
projects/core/components/alert/alert.module.ts 100.00% <ø> (ø)
projects/core/components/alert/alert.service.ts 25.00% <ø> (ø)
projects/core/tokens/i18n.ts 100.00% <ø> (ø)
.../kit/components/input-count/input-count-options.ts 100.00% <ø> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e41eb...abc0334. Read the comment docs.

projects/core/utils/dom/are-css-vars-supported.ts Outdated Show resolved Hide resolved
export const TUI_COUNTRIES_MASKS: InjectionToken<Record<TuiCountryIsoCode, string>> =
new InjectionToken<Record<TuiCountryIsoCode, string>>('Countries masks', {
factory: () => COUNTRIES_MASKS,
factory: () => ({
[TuiCountryIsoCode.AD]: '+376###-###',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember we wanted to move this out to a separate package. @rvalitov, are you still interested in it? @splincode @vladimirpotekhin @nsbarsukov what do you guys think, maybe it's time we move it out? We can at least create a repository and move this constant there so later we can separately maintain this and add some trusted source? See #917

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, should we create repo in tinkoff space or completely separate ?

@vladimirpotekhin vladimirpotekhin merged commit a35cc2f into v3.x Jul 13, 2022
@vladimirpotekhin vladimirpotekhin deleted the deprecated_stuff branch July 13, 2022 08:25
@well-done-bot
Copy link

well-done-bot bot commented Jul 13, 2022

'Well done'

tinkoff-bot pushed a commit that referenced this pull request Jul 13, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Jul 13, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Jul 14, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Jul 15, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Jul 15, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Jul 15, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Jul 15, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Jul 15, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Jul 18, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
splincode pushed a commit that referenced this pull request Jul 21, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Jul 21, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Jul 21, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Aug 1, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Aug 1, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
splincode pushed a commit that referenced this pull request Aug 3, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
splincode pushed a commit that referenced this pull request Aug 4, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Aug 4, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
splincode pushed a commit that referenced this pull request Aug 5, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
splincode pushed a commit that referenced this pull request Aug 5, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
splincode pushed a commit that referenced this pull request Aug 6, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Aug 8, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Aug 8, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Aug 8, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Aug 8, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
splincode pushed a commit that referenced this pull request Aug 9, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Aug 9, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
splincode pushed a commit that referenced this pull request Aug 10, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
splincode pushed a commit that referenced this pull request Aug 16, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
splincode pushed a commit that referenced this pull request Aug 16, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
splincode pushed a commit that referenced this pull request Aug 22, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
splincode pushed a commit that referenced this pull request Aug 23, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Aug 23, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Aug 23, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Aug 23, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
splincode pushed a commit that referenced this pull request Aug 24, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
tinkoff-bot pushed a commit that referenced this pull request Aug 24, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
splincode pushed a commit that referenced this pull request Aug 25, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
splincode pushed a commit that referenced this pull request Aug 25, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
splincode pushed a commit that referenced this pull request Aug 26, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
splincode pushed a commit that referenced this pull request Aug 30, 2022
BREAKING CHANGES: remove WithDateMaskPipeConfig, TUI_DATE_MASK, TUI_DATE_RANGE_MASK, TuiProgressColorSegmentsAsyncPipe, TuiNotificationService, TuiProgressColorSegmentsPipe, COUNTRIES, Country, second argument in TuiHideSelectedPipe
This was referenced Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants