Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-table): SortBy add directive for server-side sorting by column name #1659

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

waterplea
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #528

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Apr 20, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2022

Visit the preview URL for this PR (updated for commit 9611c80):

https://taiga-ui--pr1659-sort-by-m11sg598.web.app

(expires Thu, 21 Apr 2022 09:39:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@waterplea waterplea merged commit 7e32b44 into main Apr 21, 2022
@waterplea waterplea deleted the sort-by branch April 21, 2022 07:33
@well-done-bot
Copy link

well-done-bot bot commented Apr 21, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🚀 - Emit column names for server-sorting Table
4 participants