Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): use CSS variables for font (sizes) on textfields #1494

Merged

Conversation

loxy
Copy link
Contributor

@loxy loxy commented Mar 7, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #1471

What is the new behavior?

The textfield mixins are now using corresponding CSS variables instead of hard coded values.

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Mar 7, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #1494 (aae30d3) into main (a075a54) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1494   +/-   ##
=======================================
  Coverage   64.32%   64.32%           
=======================================
  Files         850      850           
  Lines        9416     9416           
  Branches     1838     1838           
=======================================
  Hits         6057     6057           
  Misses       2920     2920           
  Partials      439      439           
Flag Coverage Δ
addon-charts 74.69% <ø> (ø)
addon-doc 25.84% <ø> (ø)
addon-editor 46.05% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 81.39% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 82.75% <ø> (ø)
core 68.98% <ø> (ø)
kit 62.17% <ø> (ø)
summary 64.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a075a54...aae30d3. Read the comment docs.

@loxy
Copy link
Contributor Author

loxy commented Mar 8, 2022

I think the failing screenshot test come from switching the font-size from 0.69rem to 0.6875rem (--tui-font-text-xs)

@waterplea waterplea merged commit a23e777 into taiga-family:main Mar 9, 2022
@well-done-bot
Copy link

well-done-bot bot commented Mar 9, 2022

'Well done'

@loxy loxy deleted the feature/use-text-variables-on-textfields branch March 15, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants