Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): default options configuration for primitive-textfield #1249

Merged

Conversation

GinMitch
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Issue #133 is not fully implemented.

What is the new behavior?

Partial implementation of #133 for primitive-textfield component.

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jan 24, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2022

Codecov Report

Merging #1249 (1f7efe1) into main (dfbc8a4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1249   +/-   ##
=======================================
  Coverage   64.64%   64.64%           
=======================================
  Files         738      739    +1     
  Lines        8582     8588    +6     
  Branches     1727     1727           
=======================================
+ Hits         5548     5552    +4     
- Misses       2616     2617    +1     
- Partials      418      419    +1     
Flag Coverage Δ
addon-charts 72.06% <ø> (ø)
addon-doc 26.89% <ø> (ø)
addon-editor 46.05% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 81.39% <ø> (ø)
addon-tablebars ?
cdk 82.33% <ø> (ø)
core 68.53% <100.00%> (-0.01%) ⬇️
kit 63.70% <ø> (ø)
summary 64.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...primitive-textfield/primitive-textfield-options.ts 100.00% <100.00%> (ø)
...imitive-textfield/primitive-textfield.component.ts 73.33% <100.00%> (+0.73%) ⬆️
projects/core/constants/version.ts 100.00% <100.00%> (ø)
projects/core/directives/hint/hint.directive.ts 80.00% <0.00%> (-5.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c9963e...1f7efe1. Read the comment docs.

@GinMitch GinMitch marked this pull request as ready for review January 25, 2022 09:20
@waterplea waterplea merged commit af77aaf into taiga-family:main Jan 26, 2022
@well-done-bot
Copy link

well-done-bot bot commented Jan 26, 2022

'Well done'

@GinMitch GinMitch deleted the feat/primitive-textfield-options branch February 2, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants