-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): default options configuration for primitive-textfield #1249
feat(core): default options configuration for primitive-textfield #1249
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
projects/core/components/primitive-textfield/primitive-textfield.template.html
Show resolved
Hide resolved
projects/demo/src/modules/components/primitive-textfield/primitive-textfield.component.ts
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/components/primitive-textfield/examples/2/index.ts
Show resolved
Hide resolved
projects/demo/src/modules/components/primitive-textfield/examples/2/index.ts
Outdated
Show resolved
Hide resolved
projects/core/components/primitive-textfield/primitive-textfield-options.ts
Outdated
Show resolved
Hide resolved
fix-ups according to PR comments
Codecov Report
@@ Coverage Diff @@
## main #1249 +/- ##
=======================================
Coverage 64.64% 64.64%
=======================================
Files 738 739 +1
Lines 8582 8588 +6
Branches 1727 1727
=======================================
+ Hits 5548 5552 +4
- Misses 2616 2617 +1
- Partials 418 419 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fix-ups according to PR comments
fix-ups according to PR comments
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue #133 is not fully implemented.
What is the new behavior?
Partial implementation of #133 for primitive-textfield component.
Does this PR introduce a breaking change?