Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): emit tuiDropdownOpenChange on distinct values #9962

Merged

Conversation

shiv9604
Copy link
Contributor

Fixes #9609

Description :

  1. We used Subject because we are concerned about the latest value compared to maintaining the last state.
  2. Created the emitOpenChange method to centralize & handle responsibility for emitting values.
  3. Replaced previous value emission logic with the currently integrated flow.

@shiv9604 shiv9604 requested a review from a team as a code owner December 10, 2024 20:29
@shiv9604 shiv9604 requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 10, 2024 20:29
Copy link

lumberjack-bot bot commented Dec 10, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.17%. Comparing base (b94bec5) to head (c07231c).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...ectives/dropdown/dropdown-open-legacy.directive.ts 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9962      +/-   ##
==========================================
- Coverage   75.26%   66.17%   -9.09%     
==========================================
  Files        1249     1214      -35     
  Lines       19607    15702    -3905     
  Branches     2033     2307     +274     
==========================================
- Hits        14757    10391    -4366     
- Misses       4806     5073     +267     
- Partials       44      238     +194     
Flag Coverage Δ
summary 66.17% <33.33%> (-9.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Dec 10, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
304.11KB (+31B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
260.19KB +10%
demo/browser/runtime.(hash).js
43.93KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +31B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.38MB (+31B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode merged commit f8ea2f2 into taiga-family:main Dec 13, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - Multi-Select - tuiDropdownOpenChange emitting two events
3 participants