Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk): Angular v19 allowSignalWrites warning #9810

Merged
merged 1 commit into from
Nov 27, 2024
Merged

fix(cdk): Angular v19 allowSignalWrites warning #9810

merged 1 commit into from
Nov 27, 2024

Conversation

hakimio
Copy link
Contributor

@hakimio hakimio commented Nov 21, 2024

Fixes #9809

@hakimio hakimio requested a review from a team as a code owner November 21, 2024 13:48
@hakimio hakimio requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team November 21, 2024 13:48
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 21, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@hakimio hakimio changed the title fix(cdk): angular v19 "allowSignalWrites" warning fix(cdk): angular v19 allowSignalWrites warning Nov 21, 2024
@hakimio hakimio changed the title fix(cdk): angular v19 allowSignalWrites warning fix(cdk): Angular v19 allowSignalWrites warning Nov 21, 2024
@bundlemon BundleMon
Copy link

bundlemon bot commented Nov 21, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 304.4KB (+29B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 260.09KB +10%
✅ demo/browser/runtime.(hash).js
 44.03KB +10%
✅ demo/browser/styles.(hash).css
 19.63KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change +29B 0%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.34MB (+29B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@hakimio hakimio force-pushed the fix-allow-signal-writes-warning branch from e0bee43 to c461bfa Compare November 21, 2024 14:03
@hakimio
Copy link
Contributor Author

hakimio commented Nov 25, 2024

@vladimirpotekhin can you review the PR?

@splincode
Copy link
Member

I am agree with it because warnings in node and browser terminals are annoying

image terminal

image

@splincode splincode merged commit 8b6b78a into taiga-family:main Nov 27, 2024
25 of 26 checks passed
@splincode splincode added the community contribution This issue was closed by a PR from the community label Nov 27, 2024
@taiga-family-bot taiga-family-bot mentioned this pull request Nov 27, 2024
Merged
@waterplea waterplea mentioned this pull request Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@splincode splincode splincode approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner automatically assigned from taiga-family/core-team

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

Assignees
No one assigned
Labels
community contribution This issue was closed by a PR from the community
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - allowSignalWrites: true produces warning in Angular 19
3 participants
@hakimio @splincode @vladimirpotekhin