Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 - allowSignalWrites: true produces warning in Angular 19 #9809

Closed
hakimio opened this issue Nov 21, 2024 · 0 comments · Fixed by #9810
Closed

🐞 - allowSignalWrites: true produces warning in Angular 19 #9809

hakimio opened this issue Nov 21, 2024 · 0 comments · Fixed by #9810
Labels
community contribution This issue was closed by a PR from the community

Comments

@hakimio
Copy link
Contributor

hakimio commented Nov 21, 2024

Reproduction url

taiga-ui/projects/cdk/utils/miscellaneous/directive-binding.ts

Line 43 in 432a486

{allowSignalWrites: true},

Description

allowSignalWrites: true now results in a warning in Agular 19:

The 'allowSignalWrites' flag is deprecated & no longer required for effect() (writes are allowed by default)

Warning is coming from the following code:

taiga-ui/projects/cdk/utils/miscellaneous/directive-binding.ts

Line 43 in 432a486

{allowSignalWrites: true},

Taiga UI version

4.16.0

Browser Used

Chrome

OS Used

Windows
@vladimirpotekhin vladimirpotekhin added the contributions welcome Architecture is clear and community can help label Nov 21, 2024
@hakimio hakimio mentioned this issue Nov 21, 2024
Merged
@waterplea waterplea added community contribution This issue was closed by a PR from the community and removed contributions welcome Architecture is clear and community can help labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community contribution This issue was closed by a PR from the community
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cdk): Angular v19 allowSignalWrites warning hakimio/taiga-ui
3 participants
@hakimio @waterplea @vladimirpotekhin