-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cdk): redundant assert log if hours are greater than 23 #8448
fix(cdk): redundant assert log if hours are greater than 23 #8448
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
@Chiorufarewerin Could you add backport to v3.x branch? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8448 +/- ##
==========================================
- Coverage 70.19% 67.11% -3.08%
==========================================
Files 1460 1172 -288
Lines 15934 15017 -917
Branches 2292 2096 -196
==========================================
- Hits 11185 10079 -1106
- Misses 4369 4670 +301
+ Partials 380 268 -112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sure |
BundleMonUnchanged files (5)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
Closes # #8372