Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): redundant assert log if hours are greater than 23 #8448

Merged

Conversation

Chiorufarewerin
Copy link
Contributor

Closes # #8372

Copy link

lumberjack-bot bot commented Aug 9, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode splincode changed the title chore(cdk): fix redundant assert log if hours are greater than 23 fix(cdk): redundant assert log if hours are greater than 23 Aug 9, 2024
@splincode splincode added the v4 4.0 candidate label Aug 9, 2024
@splincode
Copy link
Member

@Chiorufarewerin Could you add backport to v3.x branch?

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.11%. Comparing base (43c0ebb) to head (ab5ec50).
Report is 1246 commits behind head on main.

Files Patch % Lines
projects/cdk/date-time/time.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8448      +/-   ##
==========================================
- Coverage   70.19%   67.11%   -3.08%     
==========================================
  Files        1460     1172     -288     
  Lines       15934    15017     -917     
  Branches     2292     2096     -196     
==========================================
- Hits        11185    10079    -1106     
- Misses       4369     4670     +301     
+ Partials      380      268     -112     
Flag Coverage Δ
summary 67.11% <0.00%> (-3.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chiorufarewerin
Copy link
Contributor Author

@Chiorufarewerin Could you add backport to v3.x branch?

Sure

Copy link

bundlemon bot commented Aug 9, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
277.97KB +10%
demo/browser/vendor.(hash).js
216.27KB +10%
demo/browser/runtime.(hash).js
41.19KB +10%
demo/browser/styles.(hash).css
11.55KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
6.67MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode merged commit c3a7e49 into taiga-family:main Aug 12, 2024
28 checks passed
This was referenced Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 4.0 candidate
Development

Successfully merging this pull request may close these issues.

3 participants