🐞 - InputTime has redundant assert log (dev mode only) if maxValues has non-default values

[nsbarsukov]

Playground Link

https://taiga-ui.dev/components/input-time#options-max

Description

1. Run development mode of our demo application
2. Open this example locally https://taiga-ui.dev/components/input-time#options-max
3. Enter 33:33

See devtool console:

Assertion failed: Time must be real, but got: 33 33 0 0

Expected behavior:
Disable this check

taiga-ui/projects/cdk/date-time/time.ts

Line 47 in 0d0b406

tuiInRange(hours, 0, HOURS_IN_DAY) &&

if (or other similar cases)

tuiInputTimeOptionsProvider({
    mode: 'HH:MM',
    maxValues: {HH: 47, MM: 59, SS: 59, MS: 999},
})

(or make it more flexible)

Angular version

16

Taiga UI version

4.0.0-rc.8

Which browsers have you used?

• Chrome
• Firefox
• Safari
• Edge

Which operating systems have you used?

• macOS
• Windows
• Linux
• iOS
• Android

[Chiorufarewerin]

I will try it

[Chiorufarewerin]

Why do you think that log is redundant? And i'm kinda interested why the InputTime has this ability for passing time with hours more that 23 at the first place.

I wonder if we change this behavior (passing time more than 23 hours) it will introduce breaking changes in the TuiTime for methods like isValidTime, fromAbsoluteMilliseconds, shift. We could make it flexible if we introduce another parameter maxHours/unlimitedHours or kind of like that but it will be looking awful.
I think the current TuiTime works as expected.

I think the correct way to introduce the new TuiTimeDelta (similar to python datetime.timedelta) or TuiTimeDistance, and return it from InputTimeComponent.
For example: we introduce returnValue in the TuiInputTimeOptions , that will be accepting TuiTime (default) or TuiTimeDistance (for hours greater than 23 will be throwing an error in component that acception only TuiTimeDistance).

And why InputTime is in the legacy section and all TUI_TIME_OPTIONS are deprecated?