Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 - Improve "Open on StackBlitz" tech #673

Closed
8 tasks done
waterplea opened this issue Sep 6, 2021 · 11 comments · Fixed by #790
Closed
8 tasks done

🚀 - Improve "Open on StackBlitz" tech #673

waterplea opened this issue Sep 6, 2021 · 11 comments · Fixed by #790
Assignees
@splincode
Labels
P2 This issue has medium priority

Comments

@waterplea
Copy link
Collaborator

waterplea commented Sep 6, 2021 •
edited
Loading

🚀 Feature request

Is your feature request related to a problem?

Currently we have a very basic feature of opening examples on StackBlitz. It causes multiple issues:

We need to improve it to:

  • Show the modules that are actually required in the example
  • Be flexible enough for wide area of special cases, like dialog components
  • Fix icons
  • Fix flags images in InputPhoneInternational

Bugs
@waterplea waterplea added documentation contributions welcome Architecture is clear and community can help labels Sep 6, 2021
This was referenced Sep 6, 2021
Closed
Closed
Closed
@nsbarsukov nsbarsukov assigned nsbarsukov and unassigned MarsiBarsi and waterplea Sep 28, 2021
@nsbarsukov nsbarsukov linked a pull request Sep 29, 2021 that will close this issue
chore(demo): stackblitz upgrade (example with many files) #790
Merged
9 tasks
nsbarsukov added a commit that referenced this issue Oct 6, 2021
@nsbarsukov
chore(demo): stackblitz upgrade (example with many files) (#673)
fdb1c69 
* chore(demo): stackblitz upgrade (example with many files)

* chore(demo): new classes to parse typescipt files raw content

* chore(demo): `stackblitz` fix dialog component example

* chore(demo): fix stackblitz examples with angular localize

* feat(addon-doc): `TuiDocExampleComponent` change `tui-tabs` to `tui-tabs-with-more`

* chore(addon-doc): `Example` component small style refactor

* chore(demo): fix after resolving conflicts

* chore(demo): refactor after review

* chore(demo): `isMainComponentFile` => `isPrimaryComponentFile`

* chore(demo): `TsFileModuleParser` code style change
@nsbarsukov nsbarsukov reopened this Oct 6, 2021
@nsbarsukov
Copy link
Member

nsbarsukov commented Oct 6, 2021 •
edited
Loading

  • Show the modules that are actually required in the example
  • Be flexible enough for wide area of special cases, like dialog components

@nsbarsukov nsbarsukov mentioned this issue Oct 26, 2021
Closed
9 tasks
@rvalitov
Copy link
Contributor

rvalitov commented Nov 7, 2021

Missing dependencies:
image

@waterplea
Copy link
Collaborator Author

Could be related to Angular 13 release? :)

@rvalitov
Copy link
Contributor

The problem is that I have a few bugs to report, but I can't copy and run any of the Taiga Stackblitz examples for the last couple of weeks.

And yes, it's Angular 13. But if your examples do not work with Angular 13, why did you set it in your Stackblitz at Taiga dev pages?:)
Perhaps it would be a good idea to stay with Angular 12 at Stackblitz, so at least your examples would work?

nsbarsukov added a commit that referenced this issue Nov 11, 2021
@nsbarsukov
chore(demo): fix stackblitz examples (#673)
a53ab1c
@nsbarsukov nsbarsukov mentioned this issue Nov 11, 2021
Merged
11 tasks
@nsbarsukov nsbarsukov removed a link to a pull request Nov 11, 2021
chore(demo): stackblitz upgrade (example with many files) #790
Merged
9 tasks
@nsbarsukov nsbarsukov linked a pull request Nov 11, 2021 that will close this issue
chore(demo): stackblitz upgrade (example with many files) #790
Merged
9 tasks
nsbarsukov added a commit that referenced this issue Nov 11, 2021
@nsbarsukov
chore(demo): fix stackblitz examples (#673)
34ed9d1
@waterplea
Copy link
Collaborator Author

I wonder what makes them not work with Angular 13. I know a couple of projects with Taiga UI that updated to 13 and had no troubles with the library. I guess it's something with StackBlitz. We locked it on 12.x.x for the time being so you can try checking on taiga-ui.dev/next

splincode pushed a commit that referenced this issue Nov 15, 2021
@nsbarsukov @splincode
chore(demo): fix stackblitz examples (#673)
7e278a4
@nsbarsukov
Copy link
Member

nsbarsukov commented Nov 16, 2021 •
edited
Loading

stackblitz' developers know about angular 13 problem
stackblitz/core#1657

Also, something wrong with latest version of angular 12.

It worked few days ago :(
I guess we should wait for some time.

@markwhitfeld
Copy link

markwhitfeld commented Nov 16, 2021 •
edited
Loading

@waterplea Just hopping on here to answer your question... the issues we are experiencing in StackBlitz are with the fact that Angular 13 now has *.mjs files and no commonJs files in the package. They also dropped the main field from the package.json and make heavy use of the relatively new exports field. So many things changed at once, many tooling providers are rushing to make the necessary changes at the moment.

@rvalitov
Copy link
Contributor

Also, something wrong with latest version of angular 12.
It worked few days ago :( I guess we should wait for some time.

Indeed, I can't run none of Angular 13 nor 12 examples in Stackblitz anymore. Only old saved Stackblitz projects work, but if I try to fork and modify them - they have missing dependency errors that can't be resolved.

@markwhitfeld
Copy link

FYI, StackBlitz now supports Angular 13:

Great news! Support for Angular 13 has finally rolled out.
...
For the next day or two (until 12 December 2021), there is a possibility of an initial slow down in starting up the dev server or running NGCC (or potentially even timeouts) as the packages repopulate into the cache as they are used, but it should come right after a refresh or two if you do have any issues. Anything else should be reported as a new issue.

Related StackBlitz issue comment: stackblitz/core#1657 (comment)

@nsbarsukov nsbarsukov mentioned this issue Jan 10, 2022
Merged
11 tasks
@waterplea waterplea added the P2 This issue has medium priority label Jan 20, 2022
@waterplea waterplea changed the title [FEATURE] Improve "Open on StackBlitz" tech 🚀 - Improve "Open on StackBlitz" tech Feb 1, 2022
@waterplea waterplea mentioned this issue Feb 1, 2022
Closed
27 tasks
@splincode splincode pinned this issue Mar 30, 2022
@splincode splincode mentioned this issue Apr 14, 2022
Merged
11 tasks
@splincode
Copy link
Member

#1945

@nsbarsukov nsbarsukov removed their assignment Nov 28, 2022
@splincode splincode unpinned this issue Jan 9, 2023
@splincode
Copy link
Member

#3382

@splincode splincode self-assigned this Jan 10, 2023
@waterplea waterplea removed the contributions welcome Architecture is clear and community can help label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@splincode splincode

Labels
P2 This issue has medium priority
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(demo): stackblitz upgrade (example with many files) taiga-family/taiga-ui
6 participants
@markwhitfeld @MarsiBarsi @waterplea @splincode @rvalitov @nsbarsukov