Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate exported legacy factories of providers #121

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

nsbarsukov
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the new behavior?

In next major release we should replace these functions by inlined arrow function.

Learn more:

@nsbarsukov nsbarsukov self-assigned this Sep 26, 2023
@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 6a0638c):

https://ng-web-apis-common--pr121-legacy-providers-fac-wyat8h04.web.app

(expires Wed, 27 Sep 2023 13:28:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a9d81cd8541a1a45fa12e730c551222bb3d5ceb9

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #121 (6a0638c) into main (8a4d1c0) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   89.20%   89.29%   +0.08%     
==========================================
  Files         201      201              
  Lines        1186     1186              
  Branches      128      128              
==========================================
+ Hits         1058     1059       +1     
+ Misses        104      103       -1     
  Partials       24       24              
Flag Coverage Δ
audio 79.92% <ø> (+0.18%) ⬆️
canvas 95.97% <ø> (ø)
common 100.00% <ø> (ø)
geolocation 100.00% <ø> (ø)
intersection-observer 98.00% <ø> (ø)
midi 100.00% <ø> (ø)
mutation-observer 100.00% <ø> (ø)
payment-request 100.00% <ø> (ø)
permissions 78.78% <ø> (ø)
resize-observer 100.00% <ø> (ø)
speech 100.00% <ø> (ø)
storage 100.00% <ø> (ø)
summary 89.29% <ø> (+0.08%) ⬆️
universal 100.00% <ø> (ø)
view-transition 85.71% <ø> (ø)
workers 98.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
libs/midi/src/utils/input-by-id.ts 100.00% <ø> (ø)
libs/midi/src/utils/input-by-name.ts 100.00% <ø> (ø)
libs/midi/src/utils/output-by-id.ts 100.00% <ø> (ø)
libs/midi/src/utils/output-by-name.ts 100.00% <ø> (ø)
...server/src/directives/resize-observer.directive.ts 100.00% <ø> (ø)
...ibs/universal/src/constants/universal-navigator.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nsbarsukov nsbarsukov merged commit 6ff3130 into main Sep 27, 2023
22 checks passed
@nsbarsukov nsbarsukov deleted the legacy-providers-factories-fns branch September 27, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants