Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(speech, view-transition): add peer dependencies on appropriate types #119

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

sevaru
Copy link
Contributor

@sevaru sevaru commented Sep 21, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Issue Number: #116

What is the new behavior?

Compile without errors for users of speech, view-transition

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

Visit the preview URL for this PR (updated for commit e862bc8):

https://ng-web-apis-common--pr119-116-incorrect-types-wp6rosgc.web.app

(expires Fri, 22 Sep 2023 13:21:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a9d81cd8541a1a45fa12e730c551222bb3d5ceb9

@sevaru sevaru force-pushed the 116-incorrect-types branch from 8fe4978 to e547e5c Compare September 21, 2023 13:08
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #119 (e862bc8) into main (12efc9b) will decrease coverage by 0.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   88.90%   88.24%   -0.67%     
==========================================
  Files         188      169      -19     
  Lines        1136     1080      -56     
  Branches      122      119       -3     
==========================================
- Hits         1010      953      -57     
- Misses        103      104       +1     
  Partials       23       23              
Flag Coverage Δ
audio 79.73% <ø> (-0.19%) ⬇️
canvas 95.97% <ø> (ø)
common ?
geolocation 100.00% <ø> (ø)
intersection-observer 78.78% <ø> (ø)
midi 100.00% <ø> (ø)
mutation-observer 100.00% <ø> (ø)
payment-request 100.00% <ø> (ø)
resize-observer 100.00% <ø> (ø)
speech 100.00% <ø> (ø)
storage 100.00% <ø> (ø)
summary 88.24% <ø> (-0.67%) ⬇️
universal 100.00% <ø> (ø)
view-transition 85.71% <ø> (ø)
workers 98.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sevaru sevaru force-pushed the 116-incorrect-types branch from e547e5c to e862bc8 Compare September 21, 2023 13:17
@sevaru sevaru merged commit a1ffd76 into main Sep 22, 2023
22 checks passed
@sevaru sevaru deleted the 116-incorrect-types branch September 22, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants