Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: view transition deploy #118

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix: view transition deploy #118

merged 1 commit into from
Sep 21, 2023

Conversation

sevaru
Copy link
Contributor

@sevaru sevaru commented Sep 21, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

cant deploy package view-transition

What is the new behavior?

package view-transition should be deployeable

Does this PR introduce a breaking change?

  • Yes
  • No

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 88ce999):

https://ng-web-apis-common--pr118-fix-view-transition-wa94t4hz.web.app

(expires Fri, 22 Sep 2023 10:02:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a9d81cd8541a1a45fa12e730c551222bb3d5ceb9

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #118 (88ce999) into main (fe9eb3e) will increase coverage by 0.59%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   88.90%   89.50%   +0.59%     
==========================================
  Files         188      195       +7     
  Lines        1136     1153      +17     
  Branches      122      123       +1     
==========================================
+ Hits         1010     1032      +22     
+ Misses        103      100       -3     
+ Partials       23       21       -2     
Flag Coverage Δ
audio 79.73% <ø> (-0.19%) ⬇️
canvas 95.97% <ø> (ø)
common 100.00% <ø> (ø)
geolocation 100.00% <ø> (ø)
intersection-observer 98.00% <ø> (+19.21%) ⬆️
midi 100.00% <ø> (ø)
mutation-observer 100.00% <ø> (ø)
payment-request 100.00% <ø> (ø)
resize-observer 100.00% <ø> (ø)
speech 100.00% <ø> (ø)
storage 100.00% <ø> (ø)
summary 89.50% <ø> (+0.59%) ⬆️
universal 100.00% <ø> (ø)
view-transition 85.71% <ø> (ø)
workers 98.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sevaru sevaru merged commit 12efc9b into main Sep 21, 2023
22 checks passed
@sevaru sevaru deleted the fix-view-transition-deploy branch September 21, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants