Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add view transition api package #117

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

sevaru
Copy link
Contributor

@sevaru sevaru commented Sep 15, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

image

image

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #117 (69eb47b) into main (f922e92) will decrease coverage by 0.76%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   89.66%   88.90%   -0.76%     
==========================================
  Files         193      188       -5     
  Lines        1132     1136       +4     
  Branches      122      122              
==========================================
- Hits         1015     1010       -5     
- Misses         96      103       +7     
- Partials       21       23       +2     
Flag Coverage Δ
audio 79.92% <ø> (ø)
canvas 95.97% <ø> (ø)
common 100.00% <ø> (ø)
geolocation 100.00% <ø> (ø)
intersection-observer 78.78% <ø> (-19.22%) ⬇️
midi 100.00% <ø> (ø)
mutation-observer 100.00% <ø> (ø)
payment-request 100.00% <ø> (ø)
resize-observer 100.00% <ø> (ø)
speech 100.00% <ø> (ø)
storage 100.00% <ø> (ø)
summary 88.90% <85.71%> (-0.76%) ⬇️
universal 100.00% <ø> (ø)
view-transition 85.71% <85.71%> (?)
workers 98.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...transition/src/services/view-transition.service.ts 83.33% <83.33%> (ø)
libs/view-transition/test.ts 100.00% <100.00%> (ø)

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sevaru sevaru force-pushed the view-transition-api branch 2 times, most recently from 828ca0d to b11203e Compare September 15, 2023 13:59
Copy link
Contributor

@MarsiBarsi MarsiBarsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments for now. I'll check the rest of PR later

@MarsiBarsi
Copy link
Contributor

For review: stackblitz to check demo — https://stackblitz.com/github/sevaru/ng-web-apis/tree/view-transition-api

libs/view-transition/README.md Outdated Show resolved Hide resolved
libs/view-transition/logo.svg Outdated Show resolved Hide resolved
libs/view-transition/package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@MarsiBarsi
Copy link
Contributor

For review: stackblitz to check demo — https://stackblitz.com/github/sevaru/ng-web-apis/tree/view-transition-api

by the way, do we have a quick link to "preview" env somewhere 👀 I see there is a job that deploys to firebase I dont see any links to it

@sevaru sevaru force-pushed the view-transition-api branch from b11203e to 346bc0c Compare September 15, 2023 15:38
@sevaru sevaru force-pushed the view-transition-api branch from 346bc0c to 90111bc Compare September 15, 2023 15:47
@sevaru
Copy link
Contributor Author

sevaru commented Sep 18, 2023

For review: stackblitz to check demo — https://stackblitz.com/github/sevaru/ng-web-apis/tree/view-transition-api

by the way, do we have a quick link to "preview" env somewhere 👀 I see there is a job that deploys to firebase I dont see any links to it

I think it would have printed it in step "Deploy preview" if this PR was not a fork
https://github.com/taiga-family/ng-web-apis/actions/runs/6200132900/job/16834147295?pr=117

if it would not we can use "details_url" from Firebase deploy action later
https://github.com/FirebaseExtended/action-hosting-deploy#details_url

@sevaru sevaru requested a review from MarsiBarsi September 19, 2023 15:05
@MarsiBarsi MarsiBarsi merged commit fe9eb3e into taiga-family:main Sep 20, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants