-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add view transition api package #117
Conversation
Codecov Report
@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 89.66% 88.90% -0.76%
==========================================
Files 193 188 -5
Lines 1132 1136 +4
Branches 122 122
==========================================
- Hits 1015 1010 -5
- Misses 96 103 +7
- Partials 21 23 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 19 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
828ca0d
to
b11203e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some comments for now. I'll check the rest of PR later
apps/demo/src/app/pages/view-transition/view-transition-page.component.html
Outdated
Show resolved
Hide resolved
apps/demo/src/app/pages/view-transition/view-transition-page.component.html
Outdated
Show resolved
Hide resolved
apps/demo/src/app/pages/view-transition/view-transition-page.component.less
Outdated
Show resolved
Hide resolved
For review: stackblitz to check demo — https://stackblitz.com/github/sevaru/ng-web-apis/tree/view-transition-api |
by the way, do we have a quick link to "preview" env somewhere 👀 I see there is a job that deploys to firebase I dont see any links to it |
b11203e
to
346bc0c
Compare
346bc0c
to
90111bc
Compare
I think it would have printed it in step "Deploy preview" if this PR was not a fork if it would not we can use "details_url" from Firebase deploy action later |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Other information