Avoid duplicate paths in coverage.json on Windows when using include-all-sources #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for your work. and I release this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on Windows two different paths are stored on the coverage object when using include-all-sources. The coverage data from the test run is stored using the normalized path, since it is put through path.join. The coverage data from addUncoveredFiles uses the unnormalized paths returned by grunt.file.expand.
This means on Windows every instrumented file that is executed by a test has an extra entry in the coverage file from addUncoveredFiles.
Normalizing the paths at the very start seems like an easy way to make everything consistent.