-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Metamask connection option #788
Conversation
✅ Deploy Preview for taho-development ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Might be edge case, but if: CleanShot.2023-11-29.at.18.15.57.mp4 |
Another small issue, |
Got the same issue. After having both MM and Taho installed (MM not connected to dapp yet, on Ethereum Mainnet, Arb Sepolia added to the chains list; Taho actively connected to dapp) I disabled the Taho plugin and reloaded the Subscape page (to test connecting to dapp with MM). I got black screen, and Screen.Recording.2023-11-30.at.07.02.54.movHere is what I did next, that helped with the issue:
|
When I try to connect do dapp with MM on a Ethereum network I'm asked if I allow for changing the network (that's correct). But in the dapp's logs I can see a bunch of errors at that point (I'm not sure if they are expected). Once I allow, I'm successfully connected to dapp and the network changes to Arbitrum Sepolia in MM (correct). |
Got an issue with staking:
The behavior is repeatable, I was able to grab a recording: EDIT: I did more testing and the fact that this was a fresh MM install and that dapp was adding the Arb Sepolia to MM did not matter here. Issue occurs also when Arb Sepolia is already added to MM, but user is on a different network. |
For me when I stuck in a loop when changing accounts in MM it was ok to do just a normal refresh: Screen.Recording.2023-11-30.at.09.13.43.mov |
I did some testing on Brave/Chrome, in various configurations of installed extensions (but mostly with MM installed, Taho disabled). In MM I used account imported from seed phrase and also a Ledger account. The only problems I observed are the ones mentioned in the above comments. |
Web3onboard remembers last wallet that was used. If it was MM but MM becomes unavailable then web3onboard will try to auto connect to MM and will fail. So to avoid problem with attempting auto connection to the wallet that is not available on the wallet lists let's just disable autoConnect feature for Metamask for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves #771
What
Add Metamask to supported wallets 🦊 🥲
Metamask is visible only if you don't have Taho wallet installed.
Testing