Javac target add #35
Merged
Javac target add #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 9, 2024 09:43
|
It still misses some required data to get the reason for the issue from the log file. |
This was referenced Apr 9, 2024
kelloggm
requested changes
Apr 9, 2024
I can't review this until these are done. |
added 2 commits
April 9, 2024 16:02
|
Prof. @kelloggm , please review it. |
kelloggm
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
LGTM; please merge once the nit is fixed and njit-jerse/specimin#232 is ready.
resources/test_data.json
Outdated
| "root_dir": "core/src/main/java/", | ||
| "targets": [ | ||
| { | ||
| "method": "create(Class<P>, Class<V>, String ,PropertyMetadata<V>)", |
There was a problem hiding this comment.
nit: the comma placement here seems wrong. It won't matter to Specimin (it removes spaces), but it would be easier to read this if we did it correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.