Add ability to set entity resolver when deserialize using borrowing reader #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #615 +/- ##
==========================================
- Coverage 64.64% 64.62% -0.02%
==========================================
Files 36 36
Lines 17003 16998 -5
==========================================
- Hits 10991 10985 -6
- Misses 6012 6013 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dralley
reviewed
Jun 21, 2023
Changelog.md
Outdated
| @@ -14,13 +14,15 @@ | |||
|
|
|||
| - [#609]: Added `Writer::write_serializable` to provide the capability to serialize | |||
| arbitrary types using serde when using the lower-level `Writer` API. | |||
| - [#615]: Added ability to set entity resolver when deserialize using borrowing reader. | |||
|
|
|||
| ### Bug Fixes | |||
|
|
|||
| ### Misc Changes | |||
|
|
|||
|
|
|||
| [#609]: https://github.com/tafia/quick-xml/issues/609 | |||
There was a problem hiding this comment.
Ok, will fix. Just a moment...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed, that after #583 there is no way to create a deserializer that will borrow from string and provide ability to resolve custom entities. This PR fixes this gap.