Expose dimensions methods to the public #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a bug in my platform where the
.worksheets()method would end up allocating an insane amount of memory (500 Gb) for what looked like a normal 10Mb Excel file (user uploaded). Turns out one of its sheets had a very large number of empty cells, and calamine was trying to put the entire thing in memory. I added a check in my code to stop processing sheets that exceed a certain threshold of cells. However, in order to do this, I had to fork your codebase to expose thedimensionsfunction. Otherwise, I couldn't find a way to see how big a sheet is without loading the entire thing.Posting in case it helps somebody else!