Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support DataTypeRef for shared strings and worksheet CellsReader #370

Merged
merged 7 commits into from
Dec 12, 2023

Conversation

tafia
Copy link
Owner

@tafia tafia commented Oct 25, 2023

Here is another iteration at trying to reduce memory usage.

Introduce a new DataTypeRef which is the same as DataType but with an additional SharedString variant.

The test case from #362 should be amended with:

    // Get worksheet
    let sheet = excel
        .worksheet_range_ref("NYC_311_SR_2010-2020-sample-1M")
        .unwrap()
        .unwrap();

NOTE:
Given that large test file, we may revisit a protection used against files with mostly blank cells:
https://github.com/tafia/calamine/pull/370/files#diff-bedb7172be56842bcb4be66655e6eb625dadc8a029fe3c87c6657768ef1fc8b9R662

@tafia
Copy link
Owner Author

tafia commented Oct 25, 2023

It remains to be seen if this can be ported to other file formats.

@tafia
Copy link
Owner Author

tafia commented Nov 1, 2023

cells reader and DataTypeRef have been ported to xlsb. Ods and Xls may not be possible as we need to read the whole file at once.

@tafia tafia changed the title support DataTypeRef for shared strings support DataTypeRef for shared strings and worksheet CellsReader Nov 1, 2023
@tafia tafia merged commit b72eb4f into master Dec 12, 2023
8 checks passed
@tafia tafia deleted the DataTypeRef branch December 12, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant