Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for all RoomTemperature modes #95

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

mxilievski
Copy link
Contributor

Right now there is a partial support for Room Temperature that only controls heating. This PR adds support for all Room Temperature operations:

  • RoomTemperatureHeating
  • RoomTemperatureCooling
  • RoomTemperatureAuto

@mxilievski
Copy link
Contributor Author

@tadasdanielius can't add you as an reviewer. Will appreciate if you can check this PR.

@mxilievski mxilievski changed the title Add support for RoomTemperature controls Add support for all RoomTemperature modes Jul 22, 2024
Copy link
Owner

@tadasdanielius tadasdanielius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have Room temperature thus I am just going to assume things are ok here.

@tadasdanielius tadasdanielius merged commit e6c83f6 into tadasdanielius:main Jul 25, 2024
@mxilievski mxilievski deleted the patch-1 branch July 25, 2024 19:43
@mihsu81
Copy link
Contributor

mihsu81 commented Jul 26, 2024

This PR is breaking the integration and functionality of the device in my case. #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants