Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(KL-99): apply check style #11

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

idealflower-k
Copy link
Contributor

πŸ“Œ μ—°κ΄€λœ 이슈

KL-99/checkstyle 적용

πŸ“ μž‘μ—… λ‚΄μš©

  • build.gradle 에 checkstyle pulgin을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
test {
	useJUnitPlatform()
	dependsOn 'checkstyleMain'
	dependsOn 'checkstyleTest'
}
  • test λͺ…λ Ήμ–΄ λ™μž‘μ‹œ checkstyle 검사λ₯Ό 같이 ν•©λ‹ˆλ‹€. ex) ./gradlew test
  • naver μ»¨λ²€μ…˜μ—μ„œ μ œκ³΅ν•˜λŠ” κ·œμΉ™μ„ μ‚¬μš©ν•©λ‹ˆλ‹€.
SAMPLE_ERROR(HttpStatus.BAD_REQUEST, "C999", "μƒ˜ν”Œ μ—λŸ¬μž…λ‹ˆλ‹€."),
	;
  • μœ„μ™€ 같은 ν˜•νƒœλ„ μ—λŸ¬λ‘œ μž‘νžˆμ§€λ§Œ μ•„λž˜ κ·œμΉ™μ„ μˆ˜μ •ν•˜μ—¬ λ°œμƒν•˜μ§€ μ•Šκ²Œ ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
  • <property name="tokens" value="COMMA, SAMI"/> : SAMI 제거
        <module name="NoWhitespaceBefore">
            <property name="tokens" value="COMMA"/>
            <message key="ws.preceded"
                     value="[space-after-comma-semicolon] ''{0}'' is preceded with whitespace."/>
        </module>
  • testλ₯Ό μ‹€ν–‰ ν›„ checkstyleμ—μ„œ λ°œμƒν•œ 문법 였λ₯˜λ₯Ό μˆ˜μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
  • ν…ŒμŠ€νŠΈμ‹œ λ‘œκ·Έμ°½μ— λ‚˜μ˜€λŠ” 파일경둜 ν΄λ¦­μ‹œ μ•„λž˜μ™€ 같은 .html을 μ œκ³΅ν•΄μ€λ‹ˆλ‹€. 이λ₯Ό ν™•μΈν•˜μ—¬ μˆ˜μ •μ΄ κ°€λŠ₯ν•©λ‹ˆλ‹€.

🌳 μž‘μ—… 브랜치λͺ…

KL-99/check-style-적용

πŸ“Έ μŠ€ν¬λ¦°μƒ·

스크란샷 2024-07-20 15 01 10

πŸ’¬ 리뷰 μš”κ΅¬μ‚¬ν•­

  • ν•΄λ‹Ή 사항을 μ μš©ν• μ§€ μ˜κ²¬μ„ μ œμ‹œν•΄μ£Όμ‹œλ©΄ μ’‹κ² μŠ΅λ‹ˆλ‹€!
  • normκ³Ό 같은 역할을 ν•΄μ€€λ‹€κ³  μƒκ°ν•˜μ‹œλ©΄ λ©λ‹ˆλ‹€!

- test μ‹€ν–‰μ‹œ checkstyle을 μ μš©ν•©λ‹ˆλ‹€.
- checkstyleμ—μ„œ λ°œμƒν•œ 였λ₯˜λ₯Ό μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
@idealflower-k idealflower-k added πŸ’„ Style μ½”λ“œ ν¬λ§·νŒ…, μ„Έλ―Έμ½œλ‘  λˆ„λ½, μ½”λ“œ 변경이 μ—†λŠ” 경우 πŸ› οΈ Build labels Jul 20, 2024
@idealflower-k idealflower-k self-assigned this Jul 20, 2024
Copy link

@min3m min3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쒀더 μ •ν™•ν•˜κ²Œ μ½”λ“œμΌ„λ²€μ…˜μ„ μ€€μˆ˜ ν•  수 μžˆμ„κ±° κ°™μŠ΅λ‹ˆλ‹€!
κ΄€λ ¨ λ‚΄μš© μ°ΎμœΌμ‹œλŠλΌ κ³ μƒλ§ŽμœΌμ…¨μŠ΅λ‹ˆλ‹€!

Copy link
Contributor

@ohhamma ohhamma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check style을 IntelliJμ—μ„œλ§Œ μ μš©ν•˜λŠ” 것이 μ•„λ‹Œ, κ·œμΉ™μ„ 지킀지 μ•Šμ•˜μ„ 경우 μ•„μ˜ˆ 였λ₯˜κ°€ λ‚˜κ²Œλ” μ—„κ²©ν•˜κ²Œ μ μš©ν•˜μ‹  뢀뢄을 ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€! μ˜ˆμ „ norm 생각이 λ‚˜κ³  κ·ΈλŸ¬λ„€μš” ν—ˆν—ˆ

@ohhamma ohhamma removed the request for review from 42jeelee July 22, 2024 05:02
@idealflower-k idealflower-k merged commit 83afae0 into develop Jul 22, 2024
2 checks passed
@idealflower-k idealflower-k deleted the KL-99/check-style-적용 branch July 22, 2024 05:02
@ohhamma ohhamma removed the πŸ’„ Style μ½”λ“œ ν¬λ§·νŒ…, μ„Έλ―Έμ½œλ‘  λˆ„λ½, μ½”λ“œ 변경이 μ—†λŠ” 경우 label Aug 1, 2024
@ohhamma ohhamma changed the title build(KL-99): check style 적용 chore(KL-99): check style 적용 Aug 3, 2024
@ohhamma ohhamma added βš™οΈ Chore 기타 변경사항 and removed πŸ› οΈ Build labels Aug 3, 2024
Copy link

coderabbitai bot commented Aug 3, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ohhamma ohhamma changed the title chore(KL-99): check style 적용 chore(KL-99): apply check style Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
βš™οΈ Chore 기타 변경사항
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants