-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
Deploy preview for tachiyomi ready! Built with commit 0a380a2 |
Nice! This should also take care of #26 |
Overhauled everything, I can't avoid the There are some issues which is mainly due to our setup and not Algolia itself:
|
This seems relevant: https://community.algolia.com/docsearch/tips.html |
That's good documentation, can maybe look into it today after I visit the ER. |
Got Algolia to reindex the page (it's supposed to be automatic but I guess not touching it for ~200 days made it go idle), also changed from using a stylesheet to replace styles I just modified the ejected component instead. It's an old PR so I'm not 100% sure of how right it's done, a review is appreciated |
@@ -11,6 +11,11 @@ module.exports = { | |||
docsRepo: 'tachiyomiorg/website', | |||
docsDir: 'src', | |||
logo: '/assets/media/logo.svg', | |||
algolia: { | |||
apiKey: 'fc1c45b5a3835e1882cbbf0751dfe705', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's an alright key to be "public", it's implemented exactly according to their spec
} | ||
} | ||
handleLinksWrapWidth() | ||
window.addEventListener('resize', handleLinksWrapWidth, false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also use https://developer.mozilla.org/en-US/docs/Web/API/Window/matchMedia , which is more performant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how I'd add that, this file is just ejected VuePress file (required to change the import for AlgoliaSearchBox.vue
), not something I wrote on my own, kind of how Home.vue
is just an edited default file and not custom written
* Add Algolia * Overhaul the search * Add sitemap.xml generator * Remove SCSS files * Eject components * Algolia styling * More styling x2 486f12a
Switches from the regular search to the much more powerful Algolia one, not sure if it's ready yet or not but I'd prefer a better way to style it rather than doing
!important
in the.scss
file.PR'd so you can preview the build.