Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#162375] Allow adding multiple services to order #4488

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

LeticiaErrandonea
Copy link
Contributor

Release Notes

  • Allow adding multiple services to order without requiring multiple forms

Screenshot

image

@LeticiaErrandonea LeticiaErrandonea marked this pull request as ready for review August 9, 2024 18:32
@LeticiaErrandonea LeticiaErrandonea requested a review from a team as a code owner August 9, 2024 18:32
Copy link
Contributor

@giladshanan giladshanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to change this line.

It looks like this will also change the behavior of multi-adding services with a new order - is that right? I haven't tested this, but I thought the goal was to align the behavior of creating a new order with adding to an existing order.

Copy link
Contributor

@giladshanan giladshanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeticiaErrandonea I looked into this a bit more - the current behavior when ordering multiple services from the "multi-add" view is to add X service order details with quantity of 1, where X is the value entered by the user. Since this PR changes that behavior, we will also need to change this line.:

Screenshot 2024-08-12 at 5 32 21 PM

We should also make sure to call out clear testing notes for this in the release notes.

@LeticiaErrandonea LeticiaErrandonea merged commit df17873 into master Aug 13, 2024
3 checks passed
@LeticiaErrandonea LeticiaErrandonea deleted the 162375-service_same_order_detail branch August 13, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants