Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech task: [#162316] Cross Core refactor #4431

Merged
merged 32 commits into from
Jul 22, 2024
Merged

Tech task: [#162316] Cross Core refactor #4431

merged 32 commits into from
Jul 22, 2024

Conversation

LeticiaErrandonea
Copy link
Contributor

@LeticiaErrandonea LeticiaErrandonea commented Jul 12, 2024 •
edited
Loading

Release Notes

  • Tech task: Cross Core refactor

Additional Info

  • This PR only moves almost all the extensions to the app.
  • Views are still in the engine.
  • Ability extension in still in the engine.

@LeticiaErrandonea LeticiaErrandonea force-pushed the 162316-cross_core_refactor branch 3 times, most recently from 1199f6f to 7513c50 Compare July 12, 2024 17:50
@LeticiaErrandonea LeticiaErrandonea changed the title [#162316] Cross Core refactor Tech task: [#162316] Cross Core refactor Jul 16, 2024
@LeticiaErrandonea LeticiaErrandonea marked this pull request as ready for review July 16, 2024 15:31
@LeticiaErrandonea LeticiaErrandonea requested a review from a team as a code owner July 16, 2024 15:31
LeticiaErrandonea
LeticiaErrandonea commented Jul 17, 2024
View reviewed changes
Copy link
Contributor Author

@LeticiaErrandonea LeticiaErrandonea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, but this looks great!

Thanks for finishing it @giladshanan!

app/models/reports/export_raw.rb Outdated Show resolved Hide resolved
app/views/shared/_order_detail_action_form.html.haml Show resolved Hide resolved
@giladshanan @LeticiaErrandonea
Update app/models/reports/export_raw.rb
5e71f6a 
Co-authored-by: Leticia Errandonea Mattos <[email protected]>
giladshanan
giladshanan reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@giladshanan giladshanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geting close!

app/models/order_detail.rb Outdated Show resolved Hide resolved
app/services/order_row_importer.rb Show resolved Hide resolved
app/services/order_row_importer.rb Outdated Show resolved Hide resolved
app/views/shared/_order_detail_action_form.html.haml Show resolved Hide resolved
spec/services/order_row_importer_spec.rb Outdated Show resolved Hide resolved
giladshanan
giladshanan approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@giladshanan giladshanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@LeticiaErrandonea LeticiaErrandonea merged commit 1a3b82e into master Jul 22, 2024
3 checks passed
@LeticiaErrandonea LeticiaErrandonea deleted the 162316-cross_core_refactor branch July 22, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladshanan giladshanan giladshanan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeticiaErrandonea @giladshanan