[Shared dev] [#162254] Open "Report an issue" in modal #4325
Conversation
| @@ -28,6 +28,10 @@ | |||
| top: 6px; | |||
| } | |||
|
|
|||
| #js--reportAnIssueModal { | |||
There was a problem hiding this comment.
More styles are needed as modal still looks off. Also, I think it's missing a Cancel button
There was a problem hiding this comment.
we have existing examples on the code, or you can look at bootstrap 2 docs
| redirect_to_order_id = params[:redirect_to_order_id] | ||
|
|
||
| if modal? | ||
| render partial: "instruments/actions/issues", locals: { product: @product, order_detail: @order_detail, instrument_issue: @instrument_issue, redirect_to_order_id: } |
There was a problem hiding this comment.
try moving this back to the new template
|
|
||
| if @instrument_issue.send_notification | ||
| redirect_to reservations_path, notice: text("create.success") | ||
| if redirect_to_order_id.present? |
There was a problem hiding this comment.
let's move this into a method that returns the redirect path
in that method we can check modal? and ensure we have an order to redirect to
we can also add a code comment there if needed to clarify the expected code paths
| @@ -28,6 +28,10 @@ | |||
| top: 6px; | |||
| } | |||
|
|
|||
| #js--reportAnIssueModal { | |||
There was a problem hiding this comment.
we have existing examples on the code, or you can look at bootstrap 2 docs
LeticiaErrandonea
force-pushed
the
162254-reservation_actions_modal
branch
from
629cc0a
to
7cdaa3b
Compare
| if modal? | ||
| render layout: false | ||
| end |
There was a problem hiding this comment.
I think line 11 should handle this
| @@ -1,3 +1,5 @@ | |||
| - modal_view = @redirect_to_order_id.present? | |||
There was a problem hiding this comment.
can we set this in the controller?
| .row | ||
| .span12 | ||
| %h2= text("title") | ||
| - url = facility_order_order_detail_issues_path(current_facility, @order_detail.order, @order_detail, redirect_to_order_id: @redirect_to_order_id) |
There was a problem hiding this comment.
can we set this in the controller?
| = f.input :message, as: :text, input_html: { class: "input-xxlarge" } | ||
| = f.submit text("submit"), class: "btn btn-primary" | ||
| .modal-footer | ||
| = modal_cancel_button text: "Cancel" |
| describe "Report an Issue" do | ||
| it "redirects to original order show" do | ||
| find("h3", text: cross_core_reservation_order.facility.to_s, match: :first).click | ||
| find("a", text: "Report an Issue").click |
There was a problem hiding this comment.
maybe put this into a within block to make it explicit which order detail we're reporting an issue about
Release Notes
Screenshot
Accessibility