[#162306] Make Cross core orders purchased #4302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladshanan
approved these changes
Jun 6, 2024
Co-authored-by: Gilad Shanan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Additional context
A "new" order in our codebase is a "cart". Once the user purchases it, the order changes to "purchased".
Cross core orders were created in "new" state but never updated to purchased. For instruments (the majority of our tests) it was right, as it's only updated when the reservation is confirmed.
This was causing different problems, the main ones being: cross core order wasn't visible in the Orders tab for the receiving facility, and order's user cart had the last product that was intended to be added to the project.