Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update alert font sizes and remove form banner #235

Merged
merged 2 commits into from
Jun 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions .github/workflows/pull_requests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,32 +67,6 @@ jobs:
- name: Run linter
run: npm run lint

audit:
needs: [setup]
runs-on: ubuntu-latest
steps:
- name: Checkout 🛎️
uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.ref }}
repository: ${{ github.event.pull_request.head.repo.full_name }}
fetch-depth: 0

- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: ${{ needs.setup.outputs.nvmrc }}
cache: npm

- name: Restore npm installs and Lerna setup
run: npm ci --ignore-scripts

- name: Audit Dependencies
run: npm run audit:ci
env:
OSSI_USERNAME: ${{ secrets.OSSI_USERNAME }}
OSSI_TOKEN: ${{ secrets.OSSI_TOKEN }}

test:
needs: [setup]
runs-on: ubuntu-latest
Expand Down
56 changes: 0 additions & 56 deletions system/core/src/components/FormBanner.ts

This file was deleted.

1 change: 0 additions & 1 deletion system/core/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ export * as checkboxRadioLabel from './components/CheckboxRadioLabel';
export * as childAnchors from './components/ChildAnchors';
export * as chip from './components/Chip';
export * as chipRow from './components/ChipRow';
export * as formBanner from './components/FormBanner';
export * as iconButton from './components/IconButton';
export * as inputAlert from './components/InputAlert';
export * as inputCore from './components/InputCore';
Expand Down
7 changes: 0 additions & 7 deletions system/react-css/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,6 @@ export {
export type { Props as CheckboxRadioLabelProps } from './structuredComponents/CheckboxRadioLabel';
export { Chip } from './structuredComponents/Chip';
export type { Props as ChipProps } from './structuredComponents/Chip';
export {
FormBannerCore,
FormBannerMessage,
FormBannerIconWrapper,
FormBanner
} from './structuredComponents/FormBanner';
export type { Props as FormBannerProps } from './structuredComponents/FormBanner';
export { Input } from './structuredComponents/Input';
export type { Props as InputProps } from './structuredComponents/Input';
export { InputAlert } from './structuredComponents/InputAlert';
Expand Down
8 changes: 6 additions & 2 deletions system/react-css/src/structuredComponents/Alert.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const AlertTitle = React.forwardRef<
React.HTMLAttributes<HTMLHeadingElement>
>((props, ref) => (
// eslint-disable-next-line jsx-a11y/heading-has-content
<h4
<h5
{...props}
ref={ref}
style={{ ...(props.style || {}), gridArea: 'title' }}
Expand All @@ -31,7 +31,11 @@ export const AlertDescription = React.forwardRef<
<div
{...props}
ref={ref}
style={{ ...(props.style || {}), gridArea: 'description' }}
style={{
...(props.style || {}),
gridArea: 'description',
font: 'var(--body-2)'
}}
/>
));

Expand Down
69 changes: 0 additions & 69 deletions system/react-css/src/structuredComponents/FormBanner.tsx

This file was deleted.

7 changes: 0 additions & 7 deletions system/react/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,13 +140,6 @@ export {
export type { Props as AlertProps } from './structuredComponents/Alert';
export { chipStyledComponents, Chip } from './structuredComponents/Chip';
export type { Props as ChipProps } from './structuredComponents/Chip';
export {
FormBannerCore,
FormBannerMessage,
FormBannerIconWrapper,
FormBanner
} from './structuredComponents/FormBanner';
export type { Props as FormBannerProps } from './structuredComponents/FormBanner';
export { Input } from './structuredComponents/Input';
export type { Props as InputProps } from './structuredComponents/Input';
export { InputAlertInner, InputAlert } from './structuredComponents/InputAlert';
Expand Down
3 changes: 2 additions & 1 deletion system/react/src/structuredComponents/Alert.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,13 @@ export const AlertCore = styled.div<Props>`
${alert.fullStyles}
`;

export const AlertTitle = styled.h4`
export const AlertTitle = styled.h5`
grid-area: title;
`;

export const AlertDescription = styled.div`
grid-area: description;
font: var(--body-2);
`;

export const AlertCloseButton = styled.button`
Expand Down
56 changes: 0 additions & 56 deletions system/react/src/structuredComponents/FormBanner.tsx

This file was deleted.

52 changes: 0 additions & 52 deletions system/stories/src/FormBanner.stories.tsx

This file was deleted.

Loading