-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tomb component docs #132
base: next
Are you sure you want to change the base?
Tomb component docs #132
Conversation
Started to out page and port over content and images
I think I prefer us to use more real code examples rather than images, or embedded SVGs for the case where we want some measurements. One of the reasons for this is that we can have them adapt to dark/light mode and the other is that we have a lot of actual code examples rather than view only images. |
I agree with Simeon's opinion, but I think we can merge this for now, so we can have a base to work on those improvements. Also, I'd prefer if we move the |
I think once we've squashed the commits/pushed a new commit we should get the preview deploy to review. Originally this was targeting But yea, dealing with the component previews in another PR is OK. Though I would like to remove the images for those for now and add them in other PRs when necessary as images generally shouldn't be committed to a repo if possible. The way git works is that every image ever committed into all branches are downloaded when you check out the repo so I want to avoid that if possible. |
@SimeonC where do you suggest uploading the images (the ones with the measurements)? |
TBH I've not got any good ideas around that. I've seen all sorts of things from using imgur or other free hosting sites, uploading into a github comment then using the CDN link that it resolves to. Maybe @DragonStuff has some good ideas? I kinda want that image CMS we talked about ages ago, just something that would allow us to have a S3 bucket/cdn-ish for these kind of images. (both for TK and also for our other projects like website/diner app etc) |
β Deploy Preview for tablekit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
docs: added amazing component documentation templates
π¦ Published PR as canary version:
Canary Versions
β¨ Test out this PR locally via: