Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

w-17263309: Proposed copy edits. #8

Merged
merged 2 commits into from
Nov 29, 2024
Merged

w-17263309: Proposed copy edits. #8

merged 2 commits into from
Nov 29, 2024

Conversation

smarvin
Copy link
Contributor

@smarvin smarvin commented Nov 18, 2024

A couple of spelling errors and the rest style and grammar related. The style parts are per our internal style guide...nothing the author did wrong. (The content was well written. Thank you for creating it!)

@smarvin smarvin requested a review from lszinv November 18, 2024 19:48
lszinv
lszinv previously approved these changes Nov 19, 2024
Copy link
Collaborator

@lszinv lszinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to take a look and provide feedback! It definitely reads better now :)

Copy link

Code Coverage Summary

Summary
  Generated on: 11/26/2024 - 18:44:21
  Parser: MultiReport (2x OpenCover)
  Assemblies: 2
  Classes: 52
  Files: 63
  Line coverage: 77.2%
  Covered lines: 1173
  Uncovered lines: 346
  Coverable lines: 1519
  Total lines: 5323
  Branch coverage: 56.8% (244 of 429)
  Covered branches: 244
  Total branches: 429
  Method coverage: 84.8% (229 of 270)
  Covered methods: 229
  Total methods: 270

@lszinv lszinv merged commit b4eea6e into main Nov 29, 2024
3 checks passed
@smarvin smarvin deleted the scotm-readme-copy-edits branch December 6, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants