Fix some regressions from commit 38c9dd

Move the non-None handling for patch and filter update mutations slightly, to conform to existing logic. Regressions should be removed, while we still are handling required and optional fields more gracefully. Signed-off-by: Tormod Haugland <[email protected]>
tOgg1 · Oct 26, 2023 · f6f04a0 · f6f04a0
1 parent 38c9dde
commit f6f04a0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/graphene_django_cud/mutations/batch_patch.py b/graphene_django_cud/mutations/batch_patch.py
@@ -17,8 +17,8 @@ def __init_subclass_with_meta__(
         cls,
         _meta=None,
         model=None,
-            optional_fields=(),
-            required_fields=(),
+            optional_fields=None,
+            required_fields=None,
         type_name=None,
         **kwargs,
     ):
@@ -35,8 +35,8 @@ def __init_subclass_with_meta__(
         return super().__init_subclass_with_meta__(
             _meta=_meta,
             model=model,
-            optional_fields=optional_fields,
-            required_fields=required_fields,
+            optional_fields=optional_fields or (),
+            required_fields=required_fields or (),
             type_name=input_type_name,
             **kwargs,
         )
diff --git a/graphene_django_cud/mutations/filter_update.py b/graphene_django_cud/mutations/filter_update.py
@@ -45,7 +45,7 @@ def __init_subclass_with_meta__(
         only_fields=(),  # Deprecated in favor of `fields`
         exclude=(),
         exclude_fields=(),  # Deprecated in favor of `exclude`
-            optional_fields=(),
+            optional_fields=None,  # Explicitly defaulted to None here and handled below.
         required_fields=(),
         field_types=None,
             auto_context_fields=None,

diff --git a/graphene_django_cud/mutations/patch.py b/graphene_django_cud/mutations/patch.py
@@ -17,8 +17,8 @@ def __init_subclass_with_meta__(
         cls,
         _meta=None,
         model=None,
-            optional_fields=(),
-            required_fields=(),
+            optional_fields=None,
+            required_fields=None,
         type_name=None,
         **kwargs,
     ):
@@ -35,8 +35,8 @@ def __init_subclass_with_meta__(
         return super().__init_subclass_with_meta__(
             _meta=_meta,
             model=model,
-            optional_fields=optional_fields,
-            required_fields=required_fields,
+            optional_fields=optional_fields or (),
+            required_fields=required_fields or (),
             type_name=input_type_name,
             **kwargs,
         )